From: Michael Snyder <msnyder@vmware.com>
To: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: [RFA] breakpoint.c, create_breakpoint, document that the case statement falls through.
Date: Thu, 03 Mar 2011 00:42:00 -0000 [thread overview]
Message-ID: <4D6EE3D9.2040108@vmware.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 98 bytes --]
This is what it does, and has done for >5 years, so I assume it is what
it should do...
Agree?
[-- Attachment #2: fallthru8.txt --]
[-- Type: text/plain, Size: 586 bytes --]
2011-03-02 Michael Snyder <msnyder@vmware.com>
* breakpoint.c (create_breakpoint): Document that case falls through.
Index: breakpoint.c
===================================================================
RCS file: /cvs/src/src/gdb/breakpoint.c,v
retrieving revision 1.546
diff -u -p -u -p -r1.546 breakpoint.c
--- breakpoint.c 1 Mar 2011 02:16:56 -0000 1.546
+++ breakpoint.c 3 Mar 2011 00:38:01 -0000
@@ -7843,6 +7843,7 @@ create_breakpoint (struct gdbarch *gdbar
default:
throw_exception (e);
}
+ /* FALLTHROUGH */
default:
if (!sals.nelts)
return 0;
next reply other threads:[~2011-03-03 0:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-03 0:42 Michael Snyder [this message]
2011-03-03 4:27 ` Joel Brobecker
2011-03-03 9:55 ` Pedro Alves
2011-03-03 17:11 ` Michael Snyder
2011-03-03 17:45 ` Tom Tromey
2011-03-04 18:58 ` Michael Snyder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D6EE3D9.2040108@vmware.com \
--to=msnyder@vmware.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox