From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31625 invoked by alias); 3 Mar 2011 00:42:07 -0000 Received: (qmail 31617 invoked by uid 22791); 3 Mar 2011 00:42:06 -0000 X-SWARE-Spam-Status: No, hits=-5.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-outbound-1.vmware.com (HELO smtp-outbound-1.vmware.com) (65.115.85.69) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 03 Mar 2011 00:42:02 +0000 Received: from mailhost3.vmware.com (mailhost3.vmware.com [10.16.27.45]) by smtp-outbound-1.vmware.com (Postfix) with ESMTP id 59A164F0B8 for ; Wed, 2 Mar 2011 16:42:01 -0800 (PST) Received: from msnyder-server.eng.vmware.com (promd-2s-dhcp138.eng.vmware.com [10.20.124.138]) by mailhost3.vmware.com (Postfix) with ESMTP id 50874CD9D0 for ; Wed, 2 Mar 2011 16:42:01 -0800 (PST) Message-ID: <4D6EE3D9.2040108@vmware.com> Date: Thu, 03 Mar 2011 00:42:00 -0000 From: Michael Snyder User-Agent: Thunderbird 2.0.0.24 (X11/20101201) MIME-Version: 1.0 To: "gdb-patches@sourceware.org" Subject: [RFA] breakpoint.c, create_breakpoint, document that the case statement falls through. Content-Type: multipart/mixed; boundary="------------020605030901000402060301" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00148.txt.bz2 This is a multi-part message in MIME format. --------------020605030901000402060301 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 98 This is what it does, and has done for >5 years, so I assume it is what it should do... Agree? --------------020605030901000402060301 Content-Type: text/plain; name="fallthru8.txt" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="fallthru8.txt" Content-length: 586 2011-03-02 Michael Snyder * breakpoint.c (create_breakpoint): Document that case falls through. Index: breakpoint.c =================================================================== RCS file: /cvs/src/src/gdb/breakpoint.c,v retrieving revision 1.546 diff -u -p -u -p -r1.546 breakpoint.c --- breakpoint.c 1 Mar 2011 02:16:56 -0000 1.546 +++ breakpoint.c 3 Mar 2011 00:38:01 -0000 @@ -7843,6 +7843,7 @@ create_breakpoint (struct gdbarch *gdbar default: throw_exception (e); } + /* FALLTHROUGH */ default: if (!sals.nelts) return 0; --------------020605030901000402060301--