From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-79080-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 12055 invoked by alias); 3 Mar 2011 17:45:26 -0000
Received: (qmail 12041 invoked by uid 22791); 3 Mar 2011 17:45:25 -0000
X-SWARE-Spam-Status: No, hits=-6.9 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 03 Mar 2011 17:45:14 +0000
Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p23Hiptk004688	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Thu, 3 Mar 2011 12:44:51 -0500
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199])	by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p23Hipkb017226;	Thu, 3 Mar 2011 12:44:51 -0500
Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p23HiobO008015;	Thu, 3 Mar 2011 12:44:50 -0500
Received: by opsy.redhat.com (Postfix, from userid 500)	id D308D3785EB; Thu,  3 Mar 2011 10:44:49 -0700 (MST)
From: Tom Tromey <tromey@redhat.com>
To: Michael Snyder <msnyder@vmware.com>
Cc: Joel Brobecker <brobecker@adacore.com>,        "gdb-patches\@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [RFA] breakpoint.c, create_breakpoint, document that the case statement falls through.
References: <4D6EE3D9.2040108@vmware.com> <20110303042652.GU30306@adacore.com>	<4D6FCBB1.9040507@vmware.com>
Date: Thu, 03 Mar 2011 17:45:00 -0000
In-Reply-To: <4D6FCBB1.9040507@vmware.com> (Michael Snyder's message of "Thu,	03 Mar 2011 09:11:13 -0800")
Message-ID: <m3lj0wxfn2.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-03/txt/msg00193.txt.bz2

>>>>> "Michael" == Michael Snyder <msnyder@vmware.com> writes:

Michael> No, honest, it *does* fall through!
Michael> I had to use a printf statement to convince myself.   ;-)
Michael> When the user answers "yes" to the query, it falls through.

Yeah.  Your patch is correct, or at least correct-enough.
Adding a "break" would also be correct, because sals.nelts is never 0 at
the end of this case.

Tom