Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Phil Muldoon <pmuldoon@redhat.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: tromey@redhat.com, gdb-patches@sourceware.org
Subject: Re: [patch] Implement set/show callback functions in gdb.Parameter
Date: Thu, 10 Mar 2011 14:41:00 -0000	[thread overview]
Message-ID: <m3lj0n18ki.fsf@redhat.com> (raw)
In-Reply-To: <83ei6ihd26.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 07 Mar	2011 22:48:33 +0200")

Eli Zaretskii <eliz@gnu.org> writes:


>> > Calling an operation a "parameter" is not the best idea.  Already you
>> > need to talk about "invoking a parameter", which sounds awkward.  Can
>> > we find a better word here?
>> 
>> 
>> Well this is an operation in a gdb.Parameter.  Not sure what else to
>> call it.  What do you think?
>
> Then how about rephrasing the description like this:
>
>   @value{GDBN} will call this method when @var{parameter}'s value has
>   been changed via the @code{set} API (for example, @kbd{set foo off}).
>
> Would this be accurate?
>
> For the get_show_string, I would suggest
>
>   @value{GDBN} will call this method when @var{parameter}'s
>   @code{show} API has been invoked (for example, @kbd{show foo}).
>
> WDYT?

I think it is fine.  I'll add the changes that both you and Tom want,
and commit today.

Thanks

Cheers

Phil


  reply	other threads:[~2011-03-10 12:09 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-15 17:24 Phil Muldoon
2011-02-15 18:28 ` Eli Zaretskii
2011-02-28 16:50 ` Phil Muldoon
2011-02-28 18:41 ` Tom Tromey
2011-03-07 16:04   ` Phil Muldoon
2011-03-07 19:45     ` Tom Tromey
2011-03-07 20:28     ` Eli Zaretskii
2011-03-07 20:51       ` Phil Muldoon
2011-03-07 20:56         ` Eli Zaretskii
2011-03-10 14:41           ` Phil Muldoon [this message]
2011-03-14 18:36             ` Phil Muldoon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3lj0n18ki.fsf@redhat.com \
    --to=pmuldoon@redhat.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox