From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-79521-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 15334 invoked by alias); 10 Mar 2011 12:09:20 -0000
Received: (qmail 15322 invoked by uid 22791); 10 Mar 2011 12:09:19 -0000
X-SWARE-Spam-Status: No, hits=-6.0 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 10 Mar 2011 12:09:06 +0000
Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p2AC93Wp006999	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Thu, 10 Mar 2011 07:09:03 -0500
Received: from localhost.localdomain (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p2AC91vW009316;	Thu, 10 Mar 2011 07:09:02 -0500
From: Phil Muldoon <pmuldoon@redhat.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: tromey@redhat.com, gdb-patches@sourceware.org
Subject: Re: [patch] Implement set/show callback functions in gdb.Parameter
References: <m3bp2dw9io.fsf@redhat.com> <m3d3mc80js.fsf@fleche.redhat.com>	<m34o7ehqht.fsf@redhat.com> <83fwqyhe6y.fsf@gnu.org>	<m34o7efz0t.fsf@redhat.com> <83ei6ihd26.fsf@gnu.org>
Reply-to: pmuldoon@redhat.com
X-URL: http://www.redhat.com
Date: Thu, 10 Mar 2011 14:41:00 -0000
In-Reply-To: <83ei6ihd26.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 07 Mar	2011 22:48:33 +0200")
Message-ID: <m3lj0n18ki.fsf@redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-03/txt/msg00634.txt.bz2

Eli Zaretskii <eliz@gnu.org> writes:


>> > Calling an operation a "parameter" is not the best idea.  Already you
>> > need to talk about "invoking a parameter", which sounds awkward.  Can
>> > we find a better word here?
>> 
>> 
>> Well this is an operation in a gdb.Parameter.  Not sure what else to
>> call it.  What do you think?
>
> Then how about rephrasing the description like this:
>
>   @value{GDBN} will call this method when @var{parameter}'s value has
>   been changed via the @code{set} API (for example, @kbd{set foo off}).
>
> Would this be accurate?
>
> For the get_show_string, I would suggest
>
>   @value{GDBN} will call this method when @var{parameter}'s
>   @code{show} API has been invoked (for example, @kbd{show foo}).
>
> WDYT?

I think it is fine.  I'll add the changes that both you and Tom want,
and commit today.

Thanks

Cheers

Phil