From: Phil Muldoon <pmuldoon@redhat.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: tromey@redhat.com, gdb-patches@sourceware.org
Subject: Re: [patch] Implement set/show callback functions in gdb.Parameter
Date: Mon, 07 Mar 2011 20:51:00 -0000 [thread overview]
Message-ID: <m34o7efz0t.fsf@redhat.com> (raw)
In-Reply-To: <83fwqyhe6y.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 07 Mar 2011 22:24:05 +0200")
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Phil Muldoon <pmuldoon@redhat.com>
>> Cc: gdb-patches@sourceware.org
>> Date: Mon, 07 Mar 2011 15:58:22 +0000
>>
>>
>> +@defop Operation {parameter} get_set_string self
>> +@value{GDBN} will call this method when a parameter has been
>> +invoked via the @code{set} API (for example, @kbd{set foo off}). The
>
> Calling an operation a "parameter" is not the best idea. Already you
> need to talk about "invoking a parameter", which sounds awkward. Can
> we find a better word here?
Well this is an operation in a gdb.Parameter. Not sure what else to
call it. What do you think?
>> +@defop Operation {parameter} get_show_string self, svalue
>
> Is the comma really necessary here?
Nope, deleted.
Thanks
Phil
next prev parent reply other threads:[~2011-03-07 20:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-15 17:24 Phil Muldoon
2011-02-15 18:28 ` Eli Zaretskii
2011-02-28 16:50 ` Phil Muldoon
2011-02-28 18:41 ` Tom Tromey
2011-03-07 16:04 ` Phil Muldoon
2011-03-07 19:45 ` Tom Tromey
2011-03-07 20:28 ` Eli Zaretskii
2011-03-07 20:51 ` Phil Muldoon [this message]
2011-03-07 20:56 ` Eli Zaretskii
2011-03-10 14:41 ` Phil Muldoon
2011-03-14 18:36 ` Phil Muldoon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m34o7efz0t.fsf@redhat.com \
--to=pmuldoon@redhat.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox