From: Tom Tromey <tromey@redhat.com>
To: pmuldoon@redhat.com
Cc: eliz@gnu.org, gdb-patches@sourceware.org
Subject: Re: [patch] Implement set/show callback functions in gdb.Parameter
Date: Mon, 07 Mar 2011 19:45:00 -0000 [thread overview]
Message-ID: <m34o7en30w.fsf@fleche.redhat.com> (raw)
In-Reply-To: <m34o7ehqht.fsf@redhat.com> (Phil Muldoon's message of "Mon, 07 Mar 2011 15:58:22 +0000")
>>>>> "Phil" == Phil Muldoon <pmuldoon@redhat.com> writes:
Phil> Anyway patch attached. What do you think?
Very close now.
Phil> + PyObject *set_doc_func = PyString_FromString ("get_set_string");
Phil> +
Phil> + make_cleanup_py_decref (set_doc_func);
The PyString_FromString call can fail.
So, you need a check here.
Phil> + PyObject *show_doc_func = PyString_FromString ("get_show_string");
Phil> +
Phil> + make_cleanup_py_decref (show_doc_func);
Likewise.
This is ok with those fixed.
Tom
next prev parent reply other threads:[~2011-03-07 19:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-15 17:24 Phil Muldoon
2011-02-15 18:28 ` Eli Zaretskii
2011-02-28 16:50 ` Phil Muldoon
2011-02-28 18:41 ` Tom Tromey
2011-03-07 16:04 ` Phil Muldoon
2011-03-07 19:45 ` Tom Tromey [this message]
2011-03-07 20:28 ` Eli Zaretskii
2011-03-07 20:51 ` Phil Muldoon
2011-03-07 20:56 ` Eli Zaretskii
2011-03-10 14:41 ` Phil Muldoon
2011-03-14 18:36 ` Phil Muldoon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m34o7en30w.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=pmuldoon@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox