From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17550 invoked by alias); 7 Mar 2011 19:28:58 -0000 Received: (qmail 17541 invoked by uid 22791); 7 Mar 2011 19:28:58 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 07 Mar 2011 19:28:54 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p27JSpg4013683 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 7 Mar 2011 14:28:51 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p27JSpOE029797; Mon, 7 Mar 2011 14:28:51 -0500 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p27JSonV012698; Mon, 7 Mar 2011 14:28:50 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id E1ABC378339; Mon, 7 Mar 2011 12:28:49 -0700 (MST) From: Tom Tromey To: pmuldoon@redhat.com Cc: eliz@gnu.org, gdb-patches@sourceware.org Subject: Re: [patch] Implement set/show callback functions in gdb.Parameter References: Date: Mon, 07 Mar 2011 19:45:00 -0000 In-Reply-To: (Phil Muldoon's message of "Mon, 07 Mar 2011 15:58:22 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00485.txt.bz2 >>>>> "Phil" == Phil Muldoon writes: Phil> Anyway patch attached. What do you think? Very close now. Phil> + PyObject *set_doc_func = PyString_FromString ("get_set_string"); Phil> + Phil> + make_cleanup_py_decref (set_doc_func); The PyString_FromString call can fail. So, you need a check here. Phil> + PyObject *show_doc_func = PyString_FromString ("get_show_string"); Phil> + Phil> + make_cleanup_py_decref (show_doc_func); Likewise. This is ok with those fixed. Tom