Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: "Ulrich Weigand" <uweigand@de.ibm.com>
Cc: gdb-patches@sourceware.org, matthew.gretton-dann@arm.com,
	       patches@linaro.org
Subject: Re: [rfc, arm] Always use correct execution state for single-step breakpoints
Date: Fri, 25 Mar 2011 16:19:00 -0000	[thread overview]
Message-ID: <m3k4fnw5rl.fsf@fleche.redhat.com> (raw)
In-Reply-To: <201103241831.p2OIVfSm025531@d06av02.portsmouth.uk.ibm.com>	(Ulrich Weigand's message of "Thu, 24 Mar 2011 19:31:41 +0100 (CET)")

>>>>> "Ulrich" == Ulrich Weigand <uweigand@de.ibm.com> writes:

Ulrich> This is done by means of a new global "arm_override_mode" which
Ulrich> is respected in arm_pc_is_thumb unconditionally (similar to
Ulrich> arm_force_mode_string),

Ulrich> (The global is a bit ugly, but the concept still seems right to me:
Ulrich> if at some point in the future, we actually do use two different
Ulrich> gdbarch's to represent Thumb vs. ARM, the single-step routines would
Ulrich> determine the proper gdbarch to set the breakpoint in and simply
Ulrich> use insert_single_step_breakpoint with that arch.)

I wonder whether such globals should actually be per-inferior?
I really don't know whether it would be possible to get in trouble with
this.

Tom


  reply	other threads:[~2011-03-25 15:59 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-24 18:55 Ulrich Weigand
2011-03-25 16:19 ` Tom Tromey [this message]
2011-03-25 17:12   ` Ulrich Weigand
2011-03-28  8:11 ` Yao Qi
2011-03-28 14:37   ` Ulrich Weigand
2011-03-28 18:34     ` Joel Brobecker
2011-03-29 14:14       ` Ulrich Weigand
2011-03-29 16:24         ` Joel Brobecker
2011-03-29 18:40           ` Ulrich Weigand
2011-04-01 11:58 ` Ulrich Weigand
2011-04-01 15:24   ` Fix build (was: Re: [rfc, arm] Always use correct execution state for single-step breakpoints) Pedro Alves
2011-04-01 15:41     ` Ulrich Weigand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3k4fnw5rl.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=matthew.gretton-dann@arm.com \
    --cc=patches@linaro.org \
    --cc=uweigand@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox