From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: gdb-patches@sourceware.org
Cc: matthew.gretton-dann@arm.com, patches@linaro.org
Subject: Re: [rfc, arm] Always use correct execution state for single-step breakpoints
Date: Fri, 01 Apr 2011 11:58:00 -0000 [thread overview]
Message-ID: <201104011158.p31Bwi6A021997@d06av02.portsmouth.uk.ibm.com> (raw)
In-Reply-To: <201103241831.p2OIVfSm025531@d06av02.portsmouth.uk.ibm.com> from "Ulrich Weigand" at Mar 24, 2011 07:31:41 PM
> gdb/
> * arm-tdep.h (arm_insert_single_step_breakpoint): Add prototype.
> * arm-tdep.c (arm_override_mode): New global.
> (arm_pc_is_thumb): Respect arm_override_mode. Remove single-step
> execution mode heuristics.
> (thumb_get_next_pc_raw): Remove INSERT_BKTP argument; always insert
> second single-step breakpoint if needed, using
> arm_insert_single_step_breakpoint.
> (arm_get_next_pc_raw): Remove INSERT_BKTP argument. Only handle
> ARM execution mode, do not call thumb_get_next_pc_raw.
> (arm_get_next_pc): Encode execution mode in return value. Call
> either arm_get_next_pc_raw or thumb_get_next_pc_raw.
> (arm_insert_single_step_breakpoint): New function.
> (arm_software_single_step): Call it.
> * arm-linux-tdep.c (arm_linux_sigreturn_return_addr): Add IS_THUMB
> argument to return execution mode of sigreturn target.
> (arm_linux_syscall_next_pc): Use it.
> (arm_linux_copy_svc): Update call.
> (arm_linux_software_single_step): Call
> arm_insert_single_step_breakpoint.
>
> gdb/testsuite/
> * gdb.arch/thumb-singlestep.S: New file.
> * gdb.arch/thumb-singlestep.exp: Likewise.
I've checked this in now.
Bye,
Ulrich
--
Dr. Ulrich Weigand
GNU Toolchain for Linux on System z and Cell BE
Ulrich.Weigand@de.ibm.com
next prev parent reply other threads:[~2011-04-01 11:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-24 18:55 Ulrich Weigand
2011-03-25 16:19 ` Tom Tromey
2011-03-25 17:12 ` Ulrich Weigand
2011-03-28 8:11 ` Yao Qi
2011-03-28 14:37 ` Ulrich Weigand
2011-03-28 18:34 ` Joel Brobecker
2011-03-29 14:14 ` Ulrich Weigand
2011-03-29 16:24 ` Joel Brobecker
2011-03-29 18:40 ` Ulrich Weigand
2011-04-01 11:58 ` Ulrich Weigand [this message]
2011-04-01 15:24 ` Fix build (was: Re: [rfc, arm] Always use correct execution state for single-step breakpoints) Pedro Alves
2011-04-01 15:41 ` Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201104011158.p31Bwi6A021997@d06av02.portsmouth.uk.ibm.com \
--to=uweigand@de.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=matthew.gretton-dann@arm.com \
--cc=patches@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox