Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Ulrich Weigand <uweigand@de.ibm.com>
Cc: Yao Qi <yao@codesourcery.com>, gdb-patches@sourceware.org
Subject: Re: [rfc, arm] Always use correct execution state for single-step breakpoints
Date: Mon, 28 Mar 2011 18:34:00 -0000	[thread overview]
Message-ID: <20110328171116.GC3670@adacore.com> (raw)
In-Reply-To: <201103281315.p2SDFg3F004550@d06av02.portsmouth.uk.ibm.com>

> > > +if ![runto_main] then {
> > > +    gdb_suppress_tests
> > > +}

We decided a long time ago that gdb_suppress_entire_file,
gdb_suppress_tests et al should no longer be used...

> > I am OK with part, but a question on general handling `failed to
> > runto_main'.  I noticed there are some different policies to handle
> > that, such as `fail and return', `perror and return', and
> > 'gdb_suppress_tests'.  Which on is recommended?
> 
> I don't really have a strong opinion on that, except that perror is
> probably wrong (this is supposed to be uses to signal problems in
> the test *framework* itself).  I'd say that if there is a reasonable
> expectation that starting up the test may fail on some platforms,
> a failure of runto_main ought to trigger something like UNTESTED
> or UNSUPPORTED.  Otherwise it should trigger a FAIL.

What we document right now is:

    if ![runto_main] {
        return -1
    }

(http://sourceware.org/gdb/wiki/GDBTestcaseCookbook)

We might have discussed it, but I'm not sure.  I see your point
about posting an UNTESTED OR UNSUPPORTED, which I think
prepare_for_testing does.  In fact, an old message (from
most likely DanielJ, in 2006):

> I've been using untested followed by return.  Why wouldn't that be
> ideal?

So, if that's agreeable to everyone, I will change the Cookbook
to follow that.

-- 
Joel


  reply	other threads:[~2011-03-28 17:11 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-24 18:55 Ulrich Weigand
2011-03-25 16:19 ` Tom Tromey
2011-03-25 17:12   ` Ulrich Weigand
2011-03-28  8:11 ` Yao Qi
2011-03-28 14:37   ` Ulrich Weigand
2011-03-28 18:34     ` Joel Brobecker [this message]
2011-03-29 14:14       ` Ulrich Weigand
2011-03-29 16:24         ` Joel Brobecker
2011-03-29 18:40           ` Ulrich Weigand
2011-04-01 11:58 ` Ulrich Weigand
2011-04-01 15:24   ` Fix build (was: Re: [rfc, arm] Always use correct execution state for single-step breakpoints) Pedro Alves
2011-04-01 15:41     ` Ulrich Weigand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110328171116.GC3670@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=uweigand@de.ibm.com \
    --cc=yao@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox