From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24735 invoked by alias); 25 Mar 2011 15:59:31 -0000 Received: (qmail 24726 invoked by uid 22791); 25 Mar 2011 15:59:30 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 25 Mar 2011 15:59:21 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p2PFxCFI005999 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 25 Mar 2011 11:59:12 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p2PFxCo8028790; Fri, 25 Mar 2011 11:59:12 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p2PFxAsw001478; Fri, 25 Mar 2011 11:59:11 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 4CC8E378D0A; Fri, 25 Mar 2011 09:59:10 -0600 (MDT) From: Tom Tromey To: "Ulrich Weigand" Cc: gdb-patches@sourceware.org, matthew.gretton-dann@arm.com, patches@linaro.org Subject: Re: [rfc, arm] Always use correct execution state for single-step breakpoints References: <201103241831.p2OIVfSm025531@d06av02.portsmouth.uk.ibm.com> Date: Fri, 25 Mar 2011 16:19:00 -0000 In-Reply-To: <201103241831.p2OIVfSm025531@d06av02.portsmouth.uk.ibm.com> (Ulrich Weigand's message of "Thu, 24 Mar 2011 19:31:41 +0100 (CET)") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg01098.txt.bz2 >>>>> "Ulrich" == Ulrich Weigand writes: Ulrich> This is done by means of a new global "arm_override_mode" which Ulrich> is respected in arm_pc_is_thumb unconditionally (similar to Ulrich> arm_force_mode_string), Ulrich> (The global is a bit ugly, but the concept still seems right to me: Ulrich> if at some point in the future, we actually do use two different Ulrich> gdbarch's to represent Thumb vs. ARM, the single-step routines would Ulrich> determine the proper gdbarch to set the breakpoint in and simply Ulrich> use insert_single_step_breakpoint with that arch.) I wonder whether such globals should actually be per-inferior? I really don't know whether it would be possible to get in trouble with this. Tom