Re: [python] [patch] PR python/13331

[Phil Muldoon <pmuldoon@redhat.com>]

Tom Tromey <tromey@redhat.com> writes:

>>>>>> "Phil" == Phil Muldoon <pmuldoon@redhat.com> writes:
>
> Phil> 2011-10-24  Phil Muldoon  <pmuldoon@redhat.com>
> Phil>         PR python/13331
> Phil> 	* python/py-function.c (fnpy_call): Check 'args' is not NULL.
> Phil> 	(convert_values_to_python): Return on Python tuple allocation
> Phil> 	failure.
>
> Phil> +  if (! result)
> Phil> +    return NULL;
>
> I think the function should have a single return convention.
> One easy way to do that would be to remove the 'error' call and have it
> return NULL when value_to_value_object fails.

Committed with requested change (return NULL on value conversion
error).

Cheers,

Phil