From: Tom Tromey <tromey@redhat.com>
To: Paul Koning <paulkoning@comcast.net>
Cc: gdb-patches@sourceware.org, Phil Muldoon <pmuldoon@redhat.com>
Subject: Re: [python] [patch] PR python/13331
Date: Mon, 24 Oct 2011 15:47:00 -0000 [thread overview]
Message-ID: <m3aa8qbdru.fsf@fleche.redhat.com> (raw)
In-Reply-To: <966B9848-BA1E-4777-BCE3-FD57AEA6E989@comcast.net> (Paul Koning's message of "Mon, 24 Oct 2011 11:31:07 -0400")
>>>>> "Paul" == Paul Koning <paulkoning@comcast.net> writes:
Paul> In this loop there is an example of what I mentioned: if
Paul> value_to_value_object returns NULL, exception status has been set, and
Paul> that should not be overwritten here. On the other hand, there is
Paul> missing cleanup: any objects added to the tuple before the failing
Paul> call need to have a DECREF done on them.
Won't decref'ing the tuple do this for us?
If not then I think there are a lot of similar bugs elsewhere.
But .. how could it not? That would be weird.
Paul> That should just be a cleanup and return NULL -- the
Paul> PyObject_GetAttrString has set the exception.
This (fnpy_call) is a "gdb-facing" function, so it has to use error.
It doesn't (and can't) follow the Python conventions.
Tom
next prev parent reply other threads:[~2011-10-24 15:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-24 13:30 Phil Muldoon
2011-10-24 13:57 ` Tom Tromey
[not found] ` <09787EF419216C41A903FD14EE5506DD030CE5E15C@AUSX7MCPC103.AMER.DELL.COM>
2011-10-24 15:39 ` Paul Koning
2011-10-24 15:47 ` Tom Tromey [this message]
2011-10-24 15:52 ` Paul Koning
2011-10-24 16:00 ` Phil Muldoon
2011-10-24 16:06 ` Paul Koning
2011-10-27 10:59 ` Phil Muldoon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3aa8qbdru.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=paulkoning@comcast.net \
--cc=pmuldoon@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox