From: Tom Tromey <tromey@redhat.com>
To: pmuldoon@redhat.com
Cc: gdb-patches@sourceware.org
Subject: Re: [python] [patch] PR python/13331
Date: Mon, 24 Oct 2011 13:57:00 -0000 [thread overview]
Message-ID: <m339eicxe7.fsf@fleche.redhat.com> (raw)
In-Reply-To: <m3ipne7chg.fsf@redhat.com> (Phil Muldoon's message of "Mon, 24 Oct 2011 14:20:11 +0100")
>>>>> "Phil" == Phil Muldoon <pmuldoon@redhat.com> writes:
Phil> 2011-10-24 Phil Muldoon <pmuldoon@redhat.com>
Phil> PR python/13331
Phil> * python/py-function.c (fnpy_call): Check 'args' is not NULL.
Phil> (convert_values_to_python): Return on Python tuple allocation
Phil> failure.
Phil> + if (! result)
Phil> + return NULL;
I think the function should have a single return convention.
One easy way to do that would be to remove the 'error' call and have it
return NULL when value_to_value_object fails.
Tom
next prev parent reply other threads:[~2011-10-24 13:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-24 13:30 Phil Muldoon
2011-10-24 13:57 ` Tom Tromey [this message]
[not found] ` <09787EF419216C41A903FD14EE5506DD030CE5E15C@AUSX7MCPC103.AMER.DELL.COM>
2011-10-24 15:39 ` Paul Koning
2011-10-24 15:47 ` Tom Tromey
2011-10-24 15:52 ` Paul Koning
2011-10-24 16:00 ` Phil Muldoon
2011-10-24 16:06 ` Paul Koning
2011-10-27 10:59 ` Phil Muldoon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m339eicxe7.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=pmuldoon@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox