From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-84627-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 5111 invoked by alias); 24 Oct 2011 13:49:57 -0000
Received: (qmail 5101 invoked by uid 22791); 24 Oct 2011 13:49:55 -0000
X-SWARE-Spam-Status: No, hits=-7.2 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 24 Oct 2011 13:49:38 +0000
Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p9ODncKl020566	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)	for <gdb-patches@sourceware.org>; Mon, 24 Oct 2011 09:49:38 -0400
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199])	by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p9ODncO4005010;	Mon, 24 Oct 2011 09:49:38 -0400
Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p9ODnafI004494;	Mon, 24 Oct 2011 09:49:37 -0400
From: Tom Tromey <tromey@redhat.com>
To: pmuldoon@redhat.com
Cc: gdb-patches@sourceware.org
Subject: Re: [python] [patch] PR python/13331
References: <m3ipne7chg.fsf@redhat.com>
Date: Mon, 24 Oct 2011 13:57:00 -0000
In-Reply-To: <m3ipne7chg.fsf@redhat.com> (Phil Muldoon's message of "Mon, 24	Oct 2011 14:20:11 +0100")
Message-ID: <m339eicxe7.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.90 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-10/txt/msg00630.txt.bz2

>>>>> "Phil" == Phil Muldoon <pmuldoon@redhat.com> writes:

Phil> 2011-10-24  Phil Muldoon  <pmuldoon@redhat.com>
Phil>         PR python/13331
Phil> 	* python/py-function.c (fnpy_call): Check 'args' is not NULL.
Phil> 	(convert_values_to_python): Return on Python tuple allocation
Phil> 	failure.

Phil> +  if (! result)
Phil> +    return NULL;

I think the function should have a single return convention.
One easy way to do that would be to remove the 'error' call and have it
return NULL when value_to_value_object fails.

Tom