From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19410 invoked by alias); 27 Oct 2011 10:31:39 -0000 Received: (qmail 19369 invoked by uid 22791); 27 Oct 2011 10:31:38 -0000 X-SWARE-Spam-Status: No, hits=-6.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 27 Oct 2011 10:31:18 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p9RAVIb8026461 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 27 Oct 2011 06:31:18 -0400 Received: from localhost.localdomain (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p9RAVEZE005067; Thu, 27 Oct 2011 06:31:17 -0400 From: Phil Muldoon To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [python] [patch] PR python/13331 References: Reply-to: pmuldoon@redhat.com X-URL: http://www.redhat.com Date: Thu, 27 Oct 2011 10:59:00 -0000 In-Reply-To: (Tom Tromey's message of "Mon, 24 Oct 2011 07:49:36 -0600") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-10/txt/msg00723.txt.bz2 Tom Tromey writes: >>>>>> "Phil" == Phil Muldoon writes: > > Phil> 2011-10-24 Phil Muldoon > Phil> PR python/13331 > Phil> * python/py-function.c (fnpy_call): Check 'args' is not NULL. > Phil> (convert_values_to_python): Return on Python tuple allocation > Phil> failure. > > Phil> + if (! result) > Phil> + return NULL; > > I think the function should have a single return convention. > One easy way to do that would be to remove the 'error' call and have it > return NULL when value_to_value_object fails. Committed with requested change (return NULL on value conversion error). Cheers, Phil