Re: [PATCH] PR exp/9103

[Tom Tromey <tromey@redhat.com>]

Eli> It's okay, but I have two comments:

How about this?  I tried to address your comments.

Tom

2009-03-18  Tom Tromey  <tromey@redhat.com>

	* gdb.texinfo (Requirements): Mention iconv.

diff --git a/gdb/NEWS b/gdb/NEWS
index 3f084e7..a8ddd45 100644
--- a/gdb/NEWS
+++ b/gdb/NEWS
@@ -8,7 +8,9 @@ target.  Strings whose character type is wchar_t, char16_t, or
 char32_t are now correctly printed.  GDB supports wide- and unicode-
 literals in C, that is, L'x', L"string", u'x', u"string", U'x', and
 U"string" syntax.  And, GDB allows the "%ls" and "%lc" formats in
-`printf'.
+`printf'.  This feature requires iconv to work properly; if your
+system does not have a working iconv, GDB can use GNU libiconv.  See
+the installation instructions for more information.
 
 * GDB now supports automatic retrieval of shared library files from
 remote targets.  To use this feature, specify a system root that begins
diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
index 7a49aea..44f7b4d 100644
--- a/gdb/doc/gdb.texinfo
+++ b/gdb/doc/gdb.texinfo
@@ -24734,6 +24734,24 @@ The @samp{zlib} library is likely included with your operating system
 distribution; if it is not, you can get the latest version from
 @url{http://zlib.net}.
 
+@item iconv
+@value{GDBN}'s features related to character sets (@pxref{Character
+Sets}) require a functioning @code{iconv} implementation.  If you are
+on a GNU system, then this is provided by the GNU C Library.  Some
+other systems also provide a working @code{iconv}.
+
+On systems with @code{iconv}, you can install GNU Libiconv.  If you
+have previously installed Libiconv, you can use the
+@option{--with-libiconv-prefix} option to configure.
+
+@value{GDBN}'s top-level @file{configure} and @file{Makefile} will
+arrange to build Libiconv if a directory named @file{libiconv} appears
+in the top-most source directory.  If Libiconv is built this way, and
+if the operating system does not provide a suitable @code{iconv}
+implementation, then the just-built library will automatically be used
+by @value{GDBN}.  One easy way to set this up is to download GNU
+Libiconv, unpack it, and then rename the directory holding the
+Libiconv source code to @samp{libiconv}.
 @end table
 
 @node Running Configure