Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Andre Oliveira Loureiro do Baixo <andreolb@gmail.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] PR exp/9103
Date: Wed, 11 Mar 2009 17:13:00 -0000	[thread overview]
Message-ID: <m3tz60yokm.fsf@fleche.redhat.com> (raw)
In-Reply-To: <c3f94bcc0903110949j6161078bud54d3a5240b5ccd6@mail.gmail.com> (Andre Oliveira Loureiro do Baixo's message of "Wed\, 11 Mar 2009 13\:49\:33 -0300")

>>>>> "Andre" == Andre Oliveira Loureiro do Baixo <andreolb@gmail.com> writes:

Andre> The patch works correctly because the function inside the modified
Andre> condition (val_print_string) scans the string using the size of each
Andre> character of the string. This size is passed to the function using the
Andre> parameter TYPE_LENGTH (elttype). Char * strings are printed by this
Andre> function, the only difference is that wchar_t* strings didn't get
Andre> inside the condition, and now they do.

Yeah, but it isn't as useful as it could be, because it doesn't
properly handle charset conversions.  Also, I suspect it won't work in
C, where wchar_t is a typedef.

Try this patch instead:

    http://sourceware.org/ml/gdb-patches/2009-01/msg00533.html

Tom


  reply	other threads:[~2009-03-11 17:09 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <c3f94bcc0903101928g3d767b7ah60ac81e8b6f77de@mail.gmail.com>
2009-03-11 15:37 ` Andre Oliveira Loureiro do Baixo
2009-03-11 16:30   ` Daniel Jacobowitz
2009-03-11 17:09     ` Andre Oliveira Loureiro do Baixo
2009-03-11 17:13       ` Tom Tromey [this message]
2009-03-11 18:37         ` Andre Oliveira Loureiro do Baixo
2009-03-11 20:29           ` Thiago Jung Bauermann
2009-03-11 22:25             ` Tom Tromey
2009-03-12  1:11               ` Tom Tromey
2009-03-13 23:37                 ` Joel Brobecker
2009-03-13 23:38                   ` Joel Brobecker
2009-03-14  1:41                     ` Tom Tromey
2009-03-14  0:10                   ` Mark Kettenis
2009-03-17 20:06                     ` Tom Tromey
2009-03-17 22:12                       ` Eli Zaretskii
2009-03-18  3:07                         ` Tom Tromey
2009-03-18  4:20                           ` Eli Zaretskii
2009-03-18 17:11                             ` Tom Tromey
2009-03-18 20:30                               ` Eli Zaretskii
2009-03-18  0:46                       ` Joel Brobecker
2009-03-18  1:14                         ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3tz60yokm.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=andreolb@gmail.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox