Re: [PATCH] PR exp/9103

[Joel Brobecker <brobecker@adacore.com>]

Hi Tom,

> This one includes some changes to the top-level configury for
> libiconv.  If you download libiconv, untar it in the src tree, and
> rename the directory to "libiconv", it will automatically be built.

Wow - you really went all the way to make it easy for anyone to
build GDB with a full libiconv... I don't know if it was really
necessary, but from what I saw in your patch, it didn't seem to
cost much.

> If you do not have libiconv at all, gdb will use a phony iconv that
> supports the minimum required for gdb to work.

One of the things I might add later to this is an option to force
the use of the dummy libiconv, like a --without-libiconv option
or some such.  Not sure yet if AdaCore is going to be interested
in that option, or not. If I can, I'd rather build a static libiconv
and configure GDB to use that.

> Let me know what you think.  If you have access to non-Linux hosts,
> please try this out.

I've only quickly scanned the patch, I'm a total ignorant about
iconv stuff. But I'm okay with the general approach.

-- 
Joel