From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17827 invoked by alias); 18 Mar 2009 00:35:43 -0000 Received: (qmail 17817 invoked by uid 22791); 18 Mar 2009 00:35:42 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 18 Mar 2009 00:35:36 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id E8B682BAB1C; Tue, 17 Mar 2009 20:35:34 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id Mj8Bfzv-KkzM; Tue, 17 Mar 2009 20:35:34 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id C92D02BAB11; Tue, 17 Mar 2009 20:35:32 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id DB918F5CFA; Tue, 17 Mar 2009 17:35:31 -0700 (PDT) Date: Wed, 18 Mar 2009 00:46:00 -0000 From: Joel Brobecker To: Tom Tromey Cc: Mark Kettenis , bauerman@br.ibm.com, andreolb@gmail.com, gdb-patches@sourceware.org Subject: Re: [PATCH] PR exp/9103 Message-ID: <20090318003531.GI31979@adacore.com> References: <20090311153711.GA5197@caradoc.them.org> <1236803010.11106.50.camel@localhost.localdomain> <20090313232515.GD30693@adacore.com> <200903132337.n2DNb26P011841@brahms.sibelius.xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-03/txt/msg00346.txt.bz2 Hi Tom, > This one includes some changes to the top-level configury for > libiconv. If you download libiconv, untar it in the src tree, and > rename the directory to "libiconv", it will automatically be built. Wow - you really went all the way to make it easy for anyone to build GDB with a full libiconv... I don't know if it was really necessary, but from what I saw in your patch, it didn't seem to cost much. > If you do not have libiconv at all, gdb will use a phony iconv that > supports the minimum required for gdb to work. One of the things I might add later to this is an option to force the use of the dummy libiconv, like a --without-libiconv option or some such. Not sure yet if AdaCore is going to be interested in that option, or not. If I can, I'd rather build a static libiconv and configure GDB to use that. > Let me know what you think. If you have access to non-Linux hosts, > please try this out. I've only quickly scanned the patch, I'm a total ignorant about iconv stuff. But I'm okay with the general approach. -- Joel