From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31212 invoked by alias); 18 Mar 2009 16:33:33 -0000 Received: (qmail 31189 invoked by uid 22791); 18 Mar 2009 16:33:33 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_37,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 18 Mar 2009 16:33:25 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n2IGWdmT026871; Wed, 18 Mar 2009 12:32:39 -0400 Received: from opsy.redhat.com (vpn-13-144.rdu.redhat.com [10.11.13.144]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n2IGWems016037; Wed, 18 Mar 2009 12:32:40 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 413AB3782B4; Wed, 18 Mar 2009 10:32:37 -0600 (MDT) To: Eli Zaretskii Cc: mark.kettenis@xs4all.nl, brobecker@adacore.com, bauerman@br.ibm.com, andreolb@gmail.com, gdb-patches@sourceware.org Subject: Re: [PATCH] PR exp/9103 References: <20090311153711.GA5197@caradoc.them.org> <1236803010.11106.50.camel@localhost.localdomain> <20090313232515.GD30693@adacore.com> <200903132337.n2DNb26P011841@brahms.sibelius.xs4all.nl> From: Tom Tromey Reply-To: Tom Tromey Date: Wed, 18 Mar 2009 17:11:00 -0000 In-Reply-To: (Eli Zaretskii's message of "Wed\, 18 Mar 2009 06\:19\:30 +0200") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-03/txt/msg00385.txt.bz2 Eli> It's okay, but I have two comments: How about this? I tried to address your comments. Tom 2009-03-18 Tom Tromey * gdb.texinfo (Requirements): Mention iconv. diff --git a/gdb/NEWS b/gdb/NEWS index 3f084e7..a8ddd45 100644 --- a/gdb/NEWS +++ b/gdb/NEWS @@ -8,7 +8,9 @@ target. Strings whose character type is wchar_t, char16_t, or char32_t are now correctly printed. GDB supports wide- and unicode- literals in C, that is, L'x', L"string", u'x', u"string", U'x', and U"string" syntax. And, GDB allows the "%ls" and "%lc" formats in -`printf'. +`printf'. This feature requires iconv to work properly; if your +system does not have a working iconv, GDB can use GNU libiconv. See +the installation instructions for more information. * GDB now supports automatic retrieval of shared library files from remote targets. To use this feature, specify a system root that begins diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo index 7a49aea..44f7b4d 100644 --- a/gdb/doc/gdb.texinfo +++ b/gdb/doc/gdb.texinfo @@ -24734,6 +24734,24 @@ The @samp{zlib} library is likely included with your operating system distribution; if it is not, you can get the latest version from @url{http://zlib.net}. +@item iconv +@value{GDBN}'s features related to character sets (@pxref{Character +Sets}) require a functioning @code{iconv} implementation. If you are +on a GNU system, then this is provided by the GNU C Library. Some +other systems also provide a working @code{iconv}. + +On systems with @code{iconv}, you can install GNU Libiconv. If you +have previously installed Libiconv, you can use the +@option{--with-libiconv-prefix} option to configure. + +@value{GDBN}'s top-level @file{configure} and @file{Makefile} will +arrange to build Libiconv if a directory named @file{libiconv} appears +in the top-most source directory. If Libiconv is built this way, and +if the operating system does not provide a suitable @code{iconv} +implementation, then the just-built library will automatically be used +by @value{GDBN}. One easy way to set this up is to download GNU +Libiconv, unpack it, and then rename the directory holding the +Libiconv source code to @samp{libiconv}. @end table @node Running Configure