* [RFA] python/py-utils.c, delete unused variable (?)
@ 2011-03-01 1:10 Michael Snyder
2011-03-01 1:10 ` Michael Snyder
0 siblings, 1 reply; 4+ messages in thread
From: Michael Snyder @ 2011-03-01 1:10 UTC (permalink / raw)
To: gdb-patches; +Cc: Doug Evans, tromey
This LOOKS like an unused function call, but I have no idea
whether the function has side effects.
Tom? Doug?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [RFA] python/py-utils.c, delete unused variable (?)
2011-03-01 1:10 [RFA] python/py-utils.c, delete unused variable (?) Michael Snyder
@ 2011-03-01 1:10 ` Michael Snyder
2011-03-01 14:29 ` Tom Tromey
0 siblings, 1 reply; 4+ messages in thread
From: Michael Snyder @ 2011-03-01 1:10 UTC (permalink / raw)
To: gdb-patches; +Cc: Doug Evans, tromey
[-- Attachment #1: Type: text/plain, Size: 204 bytes --]
Michael Snyder wrote:
> This LOOKS like an unused function call, but I have no idea
> whether the function has side effects.
>
> Tom? Doug?
>
Err, guess I should show you what I'm talking about...
[-- Attachment #2: unused16.txt --]
[-- Type: text/plain, Size: 651 bytes --]
2011-02-28 Michael Snyder <msnyder@vmware.com>
* python/py-utils.c (gdbpy_obj_to_string): Delete unused variable.
Index: python/py-utils.c
===================================================================
RCS file: /cvs/src/src/gdb/python/py-utils.c,v
retrieving revision 1.9
diff -u -p -u -p -r1.9 py-utils.c
--- python/py-utils.c 26 Jan 2011 20:53:45 -0000 1.9
+++ python/py-utils.c 1 Mar 2011 01:07:52 -0000
@@ -253,7 +253,6 @@ gdbpy_obj_to_string (PyObject *obj)
char *
gdbpy_exception_to_string (PyObject *ptype, PyObject *pvalue)
{
- PyObject *str_obj = PyObject_Str (pvalue);
char *str;
/* There are a few cases to consider.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [RFA] python/py-utils.c, delete unused variable (?)
2011-03-01 1:10 ` Michael Snyder
@ 2011-03-01 14:29 ` Tom Tromey
2011-03-01 19:00 ` Michael Snyder
0 siblings, 1 reply; 4+ messages in thread
From: Tom Tromey @ 2011-03-01 14:29 UTC (permalink / raw)
To: Michael Snyder; +Cc: gdb-patches, Doug Evans
>>>>> "Michael" == Michael Snyder <msnyder@vmware.com> writes:
Michael> 2011-02-28 Michael Snyder <msnyder@vmware.com>
Michael> * python/py-utils.c (gdbpy_obj_to_string): Delete unused variable.
This is ok.
Tom
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [RFA] python/py-utils.c, delete unused variable (?)
2011-03-01 14:29 ` Tom Tromey
@ 2011-03-01 19:00 ` Michael Snyder
0 siblings, 0 replies; 4+ messages in thread
From: Michael Snyder @ 2011-03-01 19:00 UTC (permalink / raw)
To: Tom Tromey; +Cc: gdb-patches, Doug Evans
Tom Tromey wrote:
>>>>>> "Michael" == Michael Snyder <msnyder@vmware.com> writes:
>
> Michael> 2011-02-28 Michael Snyder <msnyder@vmware.com>
> Michael> * python/py-utils.c (gdbpy_obj_to_string): Delete unused variable.
>
> This is ok.
Thanks, committed.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-03-01 19:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-03-01 1:10 [RFA] python/py-utils.c, delete unused variable (?) Michael Snyder
2011-03-01 1:10 ` Michael Snyder
2011-03-01 14:29 ` Tom Tromey
2011-03-01 19:00 ` Michael Snyder
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox