From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29078 invoked by alias); 1 Mar 2011 01:10:50 -0000 Received: (qmail 29067 invoked by uid 22791); 1 Mar 2011 01:10:49 -0000 X-SWARE-Spam-Status: No, hits=-5.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-outbound-2.vmware.com (HELO smtp-outbound-2.vmware.com) (65.115.85.73) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 01 Mar 2011 01:10:45 +0000 Received: from mailhost4.vmware.com (mailhost4.vmware.com [10.16.67.124]) by smtp-outbound-2.vmware.com (Postfix) with ESMTP id 63D372F003; Mon, 28 Feb 2011 17:10:44 -0800 (PST) Received: from msnyder-server.eng.vmware.com (promd-2s-dhcp138.eng.vmware.com [10.20.124.138]) by mailhost4.vmware.com (Postfix) with ESMTP id 5913CC9F93; Mon, 28 Feb 2011 17:10:44 -0800 (PST) Message-ID: <4D6C4794.4040104@vmware.com> Date: Tue, 01 Mar 2011 01:10:00 -0000 From: Michael Snyder User-Agent: Thunderbird 2.0.0.24 (X11/20101201) MIME-Version: 1.0 To: "gdb-patches@sourceware.org" CC: Doug Evans , "tromey@redhat.com" Subject: Re: [RFA] python/py-utils.c, delete unused variable (?) References: <4D6C476E.3050505@vmware.com> In-Reply-To: <4D6C476E.3050505@vmware.com> Content-Type: multipart/mixed; boundary="------------010002070603000602080808" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00008.txt.bz2 This is a multi-part message in MIME format. --------------010002070603000602080808 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 204 Michael Snyder wrote: > This LOOKS like an unused function call, but I have no idea > whether the function has side effects. > > Tom? Doug? > Err, guess I should show you what I'm talking about... --------------010002070603000602080808 Content-Type: text/plain; name="unused16.txt" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="unused16.txt" Content-length: 651 2011-02-28 Michael Snyder * python/py-utils.c (gdbpy_obj_to_string): Delete unused variable. Index: python/py-utils.c =================================================================== RCS file: /cvs/src/src/gdb/python/py-utils.c,v retrieving revision 1.9 diff -u -p -u -p -r1.9 py-utils.c --- python/py-utils.c 26 Jan 2011 20:53:45 -0000 1.9 +++ python/py-utils.c 1 Mar 2011 01:07:52 -0000 @@ -253,7 +253,6 @@ gdbpy_obj_to_string (PyObject *obj) char * gdbpy_exception_to_string (PyObject *ptype, PyObject *pvalue) { - PyObject *str_obj = PyObject_Str (pvalue); char *str; /* There are a few cases to consider. --------------010002070603000602080808--