From: Michael Snyder <msnyder@vmware.com>
To: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Cc: Doug Evans <dje@google.com>, "tromey@redhat.com" <tromey@redhat.com>
Subject: Re: [RFA] python/py-utils.c, delete unused variable (?)
Date: Tue, 01 Mar 2011 01:10:00 -0000 [thread overview]
Message-ID: <4D6C4794.4040104@vmware.com> (raw)
In-Reply-To: <4D6C476E.3050505@vmware.com>
[-- Attachment #1: Type: text/plain, Size: 204 bytes --]
Michael Snyder wrote:
> This LOOKS like an unused function call, but I have no idea
> whether the function has side effects.
>
> Tom? Doug?
>
Err, guess I should show you what I'm talking about...
[-- Attachment #2: unused16.txt --]
[-- Type: text/plain, Size: 651 bytes --]
2011-02-28 Michael Snyder <msnyder@vmware.com>
* python/py-utils.c (gdbpy_obj_to_string): Delete unused variable.
Index: python/py-utils.c
===================================================================
RCS file: /cvs/src/src/gdb/python/py-utils.c,v
retrieving revision 1.9
diff -u -p -u -p -r1.9 py-utils.c
--- python/py-utils.c 26 Jan 2011 20:53:45 -0000 1.9
+++ python/py-utils.c 1 Mar 2011 01:07:52 -0000
@@ -253,7 +253,6 @@ gdbpy_obj_to_string (PyObject *obj)
char *
gdbpy_exception_to_string (PyObject *ptype, PyObject *pvalue)
{
- PyObject *str_obj = PyObject_Str (pvalue);
char *str;
/* There are a few cases to consider.
next prev parent reply other threads:[~2011-03-01 1:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-01 1:10 Michael Snyder
2011-03-01 1:10 ` Michael Snyder [this message]
2011-03-01 14:29 ` Tom Tromey
2011-03-01 19:00 ` Michael Snyder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D6C4794.4040104@vmware.com \
--to=msnyder@vmware.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox