* [RFA] tui-winsource.c, initialize sal.pspace
@ 2011-03-02 21:15 Michael Snyder
2011-03-03 16:02 ` Tom Tromey
2011-03-03 16:59 ` Pedro Alves
0 siblings, 2 replies; 4+ messages in thread
From: Michael Snyder @ 2011-03-02 21:15 UTC (permalink / raw)
To: gdb-patches
[-- Attachment #1: Type: text/plain, Size: 51 bytes --]
Does this strike anybody as likely to be correct?
[-- Attachment #2: progspace.txt --]
[-- Type: text/plain, Size: 918 bytes --]
2011-03-02 Michael Snyder <msnyder@vmware.com>
* tui/tui-winsource.c (tui_update_source_window_as_is): Initialize
sal.pspace before calling set_current_source_symtab_and_line.
Index: tui/tui-winsource.c
===================================================================
RCS file: /cvs/src/src/gdb/tui/tui-winsource.c,v
retrieving revision 1.40
diff -u -p -u -p -r1.40 tui-winsource.c
--- tui/tui-winsource.c 27 Feb 2011 16:25:38 -0000 1.40
+++ tui/tui-winsource.c 2 Mar 2011 21:12:02 -0000
@@ -114,9 +114,11 @@ tui_update_source_window_as_is (struct t
{
struct symtab_and_line sal;
+ init_sal (&sal);
sal.line = line_or_addr.u.line_no +
(win_info->generic.content_size - 2);
sal.symtab = s;
+ sal.pspace = current_program_space;
set_current_source_symtab_and_line (&sal);
/* If the focus was in the asm win, put it in the src win if
we don't have a split layout. */
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [RFA] tui-winsource.c, initialize sal.pspace
2011-03-02 21:15 [RFA] tui-winsource.c, initialize sal.pspace Michael Snyder
@ 2011-03-03 16:02 ` Tom Tromey
2011-03-03 16:59 ` Pedro Alves
1 sibling, 0 replies; 4+ messages in thread
From: Tom Tromey @ 2011-03-03 16:02 UTC (permalink / raw)
To: Michael Snyder; +Cc: gdb-patches
>>>>> "Michael" == Michael Snyder <msnyder@vmware.com> writes:
Michael> 2011-03-02 Michael Snyder <msnyder@vmware.com>
Michael> * tui/tui-winsource.c (tui_update_source_window_as_is): Initialize
Michael> sal.pspace before calling set_current_source_symtab_and_line.
It seems reasonable to me.
Tom
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [RFA] tui-winsource.c, initialize sal.pspace
2011-03-02 21:15 [RFA] tui-winsource.c, initialize sal.pspace Michael Snyder
2011-03-03 16:02 ` Tom Tromey
@ 2011-03-03 16:59 ` Pedro Alves
2011-03-03 17:29 ` Michael Snyder
1 sibling, 1 reply; 4+ messages in thread
From: Pedro Alves @ 2011-03-03 16:59 UTC (permalink / raw)
To: gdb-patches; +Cc: Michael Snyder
On Wednesday 02 March 2011 21:15:14, Michael Snyder wrote:
> @@ -114,9 +114,11 @@ tui_update_source_window_as_is (struct t
> {
> struct symtab_and_line sal;
>
> + init_sal (&sal);
This is good.
> sal.line = line_or_addr.u.line_no +
> (win_info->generic.content_size - 2);
> sal.symtab = s;
> + sal.pspace = current_program_space;
Make this s->objfile->pspace instead.
> set_current_source_symtab_and_line (&sal);
--
Pedro Alves
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [RFA] tui-winsource.c, initialize sal.pspace
2011-03-03 16:59 ` Pedro Alves
@ 2011-03-03 17:29 ` Michael Snyder
0 siblings, 0 replies; 4+ messages in thread
From: Michael Snyder @ 2011-03-03 17:29 UTC (permalink / raw)
To: Pedro Alves; +Cc: gdb-patches
Pedro Alves wrote:
> On Wednesday 02 March 2011 21:15:14, Michael Snyder wrote:
>> @@ -114,9 +114,11 @@ tui_update_source_window_as_is (struct t
>> {
>> struct symtab_and_line sal;
>>
>> + init_sal (&sal);
>
> This is good.
>
>> sal.line = line_or_addr.u.line_no +
>> (win_info->generic.content_size - 2);
>> sal.symtab = s;
>> + sal.pspace = current_program_space;
>
> Make this s->objfile->pspace instead.
Thanks! Done.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-03-03 17:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-03-02 21:15 [RFA] tui-winsource.c, initialize sal.pspace Michael Snyder
2011-03-03 16:02 ` Tom Tromey
2011-03-03 16:59 ` Pedro Alves
2011-03-03 17:29 ` Michael Snyder
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox