Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Michael Snyder <msnyder@vmware.com>
To: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: [RFA] tui-winsource.c, initialize sal.pspace
Date: Wed, 02 Mar 2011 21:15:00 -0000	[thread overview]
Message-ID: <4D6EB362.705@vmware.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 51 bytes --]

Does this strike anybody as likely to be correct?


[-- Attachment #2: progspace.txt --]
[-- Type: text/plain, Size: 918 bytes --]

2011-03-02  Michael Snyder  <msnyder@vmware.com>

	* tui/tui-winsource.c (tui_update_source_window_as_is): Initialize
	sal.pspace before calling set_current_source_symtab_and_line.

Index: tui/tui-winsource.c
===================================================================
RCS file: /cvs/src/src/gdb/tui/tui-winsource.c,v
retrieving revision 1.40
diff -u -p -u -p -r1.40 tui-winsource.c
--- tui/tui-winsource.c	27 Feb 2011 16:25:38 -0000	1.40
+++ tui/tui-winsource.c	2 Mar 2011 21:12:02 -0000
@@ -114,9 +114,11 @@ tui_update_source_window_as_is (struct t
 	{
 	  struct symtab_and_line sal;
 	  
+	  init_sal (&sal);
 	  sal.line = line_or_addr.u.line_no +
 	    (win_info->generic.content_size - 2);
 	  sal.symtab = s;
+	  sal.pspace = current_program_space;
 	  set_current_source_symtab_and_line (&sal);
 	  /* If the focus was in the asm win, put it in the src win if
 	     we don't have a split layout.  */

             reply	other threads:[~2011-03-02 21:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-02 21:15 Michael Snyder [this message]
2011-03-03 16:02 ` Tom Tromey
2011-03-03 16:59 ` Pedro Alves
2011-03-03 17:29   ` Michael Snyder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D6EB362.705@vmware.com \
    --to=msnyder@vmware.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox