From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13248 invoked by alias); 3 Mar 2011 17:29:13 -0000 Received: (qmail 13239 invoked by uid 22791); 3 Mar 2011 17:29:12 -0000 X-SWARE-Spam-Status: No, hits=-5.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-outbound-2.vmware.com (HELO smtp-outbound-2.vmware.com) (65.115.85.73) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 03 Mar 2011 17:29:06 +0000 Received: from mailhost3.vmware.com (mailhost3.vmware.com [10.16.27.45]) by smtp-outbound-2.vmware.com (Postfix) with ESMTP id 5D7E05005; Thu, 3 Mar 2011 09:29:05 -0800 (PST) Received: from msnyder-server.eng.vmware.com (promd-2s-dhcp138.eng.vmware.com [10.20.124.138]) by mailhost3.vmware.com (Postfix) with ESMTP id 53481CD959; Thu, 3 Mar 2011 09:29:05 -0800 (PST) Message-ID: <4D6FCFE0.9080503@vmware.com> Date: Thu, 03 Mar 2011 17:29:00 -0000 From: Michael Snyder User-Agent: Thunderbird 2.0.0.24 (X11/20101201) MIME-Version: 1.0 To: Pedro Alves CC: "gdb-patches@sourceware.org" Subject: Re: [RFA] tui-winsource.c, initialize sal.pspace References: <4D6EB362.705@vmware.com> <201103031659.27706.pedro@codesourcery.com> In-Reply-To: <201103031659.27706.pedro@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00186.txt.bz2 Pedro Alves wrote: > On Wednesday 02 March 2011 21:15:14, Michael Snyder wrote: >> @@ -114,9 +114,11 @@ tui_update_source_window_as_is (struct t >> { >> struct symtab_and_line sal; >> >> + init_sal (&sal); > > This is good. > >> sal.line = line_or_addr.u.line_no + >> (win_info->generic.content_size - 2); >> sal.symtab = s; >> + sal.pspace = current_program_space; > > Make this s->objfile->pspace instead. Thanks! Done.