Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* [PATCH] Move VEC (const_char_ptr) to gdb_vecs.h
@ 2012-04-20  4:26 Sergio Durigan Junior
  2012-04-20  4:58 ` Sergio Durigan Junior
  2012-04-20  7:21 ` Yao Qi
  0 siblings, 2 replies; 5+ messages in thread
From: Sergio Durigan Junior @ 2012-04-20  4:26 UTC (permalink / raw)
  To: gdb-patches

Hi,

This patch moves the definition of VEC (const_char_ptr) to gdb_vecs.h.
It is rather obvious, but I decided to ask either way.  Ok to apply?

The reason behind this change is that the next iteration of the
SystemTap integration patch is going to need it.

Thanks,

-- 
Sergio

2012-20-04  Sergio Durigan Junior  <sergiodj@redhat.com>

	* cp-support.h: Include `gdb_vecs.h'.  Delete `const_char_ptr' VEC
	declaration.
	* gdb_vecs.h: Declare `const_char_ptr' VEC.

diff --git a/gdb/cp-support.h b/gdb/cp-support.h
index 5988418..03ccb73 100644
--- a/gdb/cp-support.h
+++ b/gdb/cp-support.h
@@ -26,6 +26,7 @@
 
 #include "symtab.h"
 #include "vec.h"
+#include "gdb_vecs.h"
 #include "gdb_obstack.h"
 
 /* Opaque declarations.  */
@@ -174,8 +175,6 @@ extern struct type *cp_lookup_rtti_type (const char *name,
 
 extern int cp_is_anonymous (const char *namespace);
 
-DEF_VEC_P (const_char_ptr);
-
 extern void cp_add_using_directive (const char *dest,
                                     const char *src,
                                     const char *alias,
diff --git a/gdb/gdb_vecs.h b/gdb/gdb_vecs.h
index b9e0b14..ce32de3 100644
--- a/gdb/gdb_vecs.h
+++ b/gdb/gdb_vecs.h
@@ -25,6 +25,8 @@
 
 DEF_VEC_P (char_ptr);
 
+DEF_VEC_P (const_char_ptr);
+
 /* From utils.c: */
 
 extern void free_char_ptr_vec (VEC (char_ptr) *char_ptr_vec);


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] Move VEC (const_char_ptr) to gdb_vecs.h
  2012-04-20  4:26 [PATCH] Move VEC (const_char_ptr) to gdb_vecs.h Sergio Durigan Junior
@ 2012-04-20  4:58 ` Sergio Durigan Junior
  2012-04-20  7:21 ` Yao Qi
  1 sibling, 0 replies; 5+ messages in thread
From: Sergio Durigan Junior @ 2012-04-20  4:58 UTC (permalink / raw)
  To: gdb-patches

On Friday, April 20 2012, I wrote:

> Hi,

Sorry, I sent this last e-mail with my personal email account.  Please,
if it's not much of a burden, reply to my Red Hat email.

Thanks,

-- 
Sergio


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] Move VEC (const_char_ptr) to gdb_vecs.h
  2012-04-20  4:26 [PATCH] Move VEC (const_char_ptr) to gdb_vecs.h Sergio Durigan Junior
  2012-04-20  4:58 ` Sergio Durigan Junior
@ 2012-04-20  7:21 ` Yao Qi
  2012-04-20 15:02   ` Tom Tromey
  1 sibling, 1 reply; 5+ messages in thread
From: Yao Qi @ 2012-04-20  7:21 UTC (permalink / raw)
  To: gdb-patches; +Cc: sergiodj

On 04/20/2012 12:23 PM, Sergio Durigan Junior wrote:
> This patch moves the definition of VEC (const_char_ptr) to gdb_vecs.h.
> It is rather obvious, but I decided to ask either way.  Ok to apply?

It is right to me, but I am not the people to approve it.  IIRC,
gdb_vecs.h is created to put several DEF_VEC_P in it.

-- 
Yao (齐尧)


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] Move VEC (const_char_ptr) to gdb_vecs.h
  2012-04-20  7:21 ` Yao Qi
@ 2012-04-20 15:02   ` Tom Tromey
  2012-04-20 18:05     ` Sergio Durigan Junior
  0 siblings, 1 reply; 5+ messages in thread
From: Tom Tromey @ 2012-04-20 15:02 UTC (permalink / raw)
  To: Yao Qi; +Cc: gdb-patches, sergiodj

>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:

Yao> On 04/20/2012 12:23 PM, Sergio Durigan Junior wrote:
>> This patch moves the definition of VEC (const_char_ptr) to gdb_vecs.h.
>> It is rather obvious, but I decided to ask either way.  Ok to apply?

Yao> It is right to me, but I am not the people to approve it.  IIRC,
Yao> gdb_vecs.h is created to put several DEF_VEC_P in it.

Yeah.

The patch is ok.

Tom


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] Move VEC (const_char_ptr) to gdb_vecs.h
  2012-04-20 15:02   ` Tom Tromey
@ 2012-04-20 18:05     ` Sergio Durigan Junior
  0 siblings, 0 replies; 5+ messages in thread
From: Sergio Durigan Junior @ 2012-04-20 18:05 UTC (permalink / raw)
  To: Tom Tromey; +Cc: Yao Qi, gdb-patches

On Friday, April 20 2012, Tom Tromey wrote:

>>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:
>
> Yao> On 04/20/2012 12:23 PM, Sergio Durigan Junior wrote:
>>> This patch moves the definition of VEC (const_char_ptr) to gdb_vecs.h.
>>> It is rather obvious, but I decided to ask either way.  Ok to apply?
>
> Yao> It is right to me, but I am not the people to approve it.  IIRC,
> Yao> gdb_vecs.h is created to put several DEF_VEC_P in it.
>
> Yeah.
>
> The patch is ok.

Thanks, committed.

  http://sourceware.org/ml/gdb-cvs/2012-04/msg00165.html

-- 
Sergio


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2012-04-20 16:58 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-04-20  4:26 [PATCH] Move VEC (const_char_ptr) to gdb_vecs.h Sergio Durigan Junior
2012-04-20  4:58 ` Sergio Durigan Junior
2012-04-20  7:21 ` Yao Qi
2012-04-20 15:02   ` Tom Tromey
2012-04-20 18:05     ` Sergio Durigan Junior

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox