From: Jim Blandy <jimb@codesourcery.com>
To: "Maciej W. Rozycki" <macro@mips.com>
Cc: gdb-patches@sourceware.org, "Maciej W. Rozycki" <macro@linux-mips.org>
Subject: Re: gdb.base/dump.exp: Force the correct endianness
Date: Wed, 25 Jul 2007 16:47:00 -0000 [thread overview]
Message-ID: <m3fy3cii91.fsf@codesourcery.com> (raw)
In-Reply-To: <Pine.LNX.4.61.0707241727040.20726@perivale.mips.com> (Maciej W. Rozycki's message of "Tue, 24 Jul 2007 17:40:35 +0100 (BST)")
"Maciej W. Rozycki" <macro@mips.com> writes:
> Testcases in gdb.base/dump.exp use binary formats that do not carry
> endianness information. This causes failures if gdb supports both
> endiannesses, but the original binary used by the script is of the
> non-default one.
>
> The following fix has been successfully tested for mipsisa32-sde-elf,
> with the mips-sim-sde32/-EB and mips-sim-sde32/-EL target boards. Gdb
> defaults to the big endianness in this configuration, so with the latter
> board dumps of arrays from SREC and hex formats are currently seen
> endian-reversed.
>
> 2007-07-24 Maciej W. Rozycki <macro@mips.com>
>
> * gdb.base/dump.exp: Force the correct endianness for binary
> formats not carrying this information.
>
> OK to apply?
This looks reasonable --- please apply it, if you've also tested it on
some desktop-like system.
Also, you should go ahead and add yourself at the proper point in the
"Write After Approval" section of gdb/MAINTAINERS, as a separate
commit, with a ChangeLog entry.
next prev parent reply other threads:[~2007-07-25 16:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-24 17:35 Maciej W. Rozycki
2007-07-25 16:47 ` Jim Blandy [this message]
2007-07-25 17:58 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3fy3cii91.fsf@codesourcery.com \
--to=jimb@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=macro@linux-mips.org \
--cc=macro@mips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox