From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-49948-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 24098 invoked by alias); 25 Jul 2007 16:02:52 -0000
Received: (qmail 24066 invoked by uid 22791); 25 Jul 2007 16:02:49 -0000
X-Spam-Check-By: sourceware.org
Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 25 Jul 2007 16:02:46 +0000
Received: (qmail 23065 invoked from network); 25 Jul 2007 16:02:39 -0000
Received: from unknown (HELO localhost) (jimb@127.0.0.2)   by mail.codesourcery.com with ESMTPA; 25 Jul 2007 16:02:39 -0000
To: "Maciej W. Rozycki" <macro@mips.com>
Cc: gdb-patches@sourceware.org,  "Maciej W. Rozycki" <macro@linux-mips.org>
Subject: Re: gdb.base/dump.exp: Force the correct endianness
References: <Pine.LNX.4.61.0707241727040.20726@perivale.mips.com>
From: Jim Blandy <jimb@codesourcery.com>
Date: Wed, 25 Jul 2007 16:47:00 -0000
In-Reply-To: <Pine.LNX.4.61.0707241727040.20726@perivale.mips.com> (Maciej W. Rozycki's message of "Tue, 24 Jul 2007 17:40:35 +0100 (BST)")
Message-ID: <m3fy3cii91.fsf@codesourcery.com>
User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2007-07/txt/msg00273.txt.bz2


"Maciej W. Rozycki" <macro@mips.com> writes:
>  Testcases in gdb.base/dump.exp use binary formats that do not carry 
> endianness information.  This causes failures if gdb supports both 
> endiannesses, but the original binary used by the script is of the 
> non-default one.
>
>  The following fix has been successfully tested for mipsisa32-sde-elf, 
> with the mips-sim-sde32/-EB and mips-sim-sde32/-EL target boards.  Gdb 
> defaults to the big endianness in this configuration, so with the latter 
> board dumps of arrays from SREC and hex formats are currently seen 
> endian-reversed.
>
> 2007-07-24  Maciej W. Rozycki  <macro@mips.com>
>
> 	* gdb.base/dump.exp: Force the correct endianness for binary
> 	formats not carrying this information.
>
>  OK to apply?

This looks reasonable --- please apply it, if you've also tested it on
some desktop-like system.

Also, you should go ahead and add yourself at the proper point in the
"Write After Approval" section of gdb/MAINTAINERS, as a separate
commit, with a ChangeLog entry.