Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Maciej W. Rozycki" <macro@mips.com>
To: gdb-patches@sourceware.org
Cc: "Maciej W. Rozycki" <macro@linux-mips.org>
Subject: gdb.base/dump.exp: Force the correct endianness
Date: Tue, 24 Jul 2007 17:35:00 -0000	[thread overview]
Message-ID: <Pine.LNX.4.61.0707241727040.20726@perivale.mips.com> (raw)

Hello,

 Testcases in gdb.base/dump.exp use binary formats that do not carry 
endianness information.  This causes failures if gdb supports both 
endiannesses, but the original binary used by the script is of the 
non-default one.

 The following fix has been successfully tested for mipsisa32-sde-elf, 
with the mips-sim-sde32/-EB and mips-sim-sde32/-EL target boards.  Gdb 
defaults to the big endianness in this configuration, so with the latter 
board dumps of arrays from SREC and hex formats are currently seen 
endian-reversed.

2007-07-24  Maciej W. Rozycki  <macro@mips.com>

	* gdb.base/dump.exp: Force the correct endianness for binary
	formats not carrying this information.

 OK to apply?

  Maciej

gdb-dump-endian.diff
Index: gdb/src/gdb/testsuite/gdb.base/dump.exp
===================================================================
--- gdb.orig/src/gdb/testsuite/gdb.base/dump.exp	2007-01-09 17:59:11.000000000 +0000
+++ gdb/src/gdb/testsuite/gdb.base/dump.exp	2007-07-24 17:25:17.000000000 +0100
@@ -34,6 +34,7 @@
 set options  {debug}
 
 set is64bitonly "no"
+set endian "auto"
 
 if [istarget "alpha*-*-*"] then {
     # SREC etc cannot handle 64-bit addresses.  Force the test
@@ -70,6 +71,19 @@
     return -1
 }
 
+# Get the endianness for the later use with endianless formats.
+
+send_gdb "show endian\n"
+gdb_expect {
+    -re ".* (big|little) endian.*$gdb_prompt $" { 
+	set endian $expect_out(1,string) 
+	pass "endianness: $endian"
+    }
+    default {
+	fail "(timeout) getting target endianness"
+    }
+}
+
 # Now generate some dump files.
 
 proc make_dump_file { command msg } {
@@ -190,6 +204,18 @@
 gdb_start
 gdb_file_cmd ${binfile}
 
+# Now fix the endianness at the correct state.
+
+send_gdb "set endian $endian\n"
+gdb_expect {
+    -re ".* (big|little) endian.*$gdb_prompt $" { 
+	pass "setting $endian endianness"
+    }
+    default {
+	fail "(timeout) setting $endian endianness"
+    }
+}
+
 # Reload saved values one by one, and compare.
 
 if { ![string compare $array_val \


             reply	other threads:[~2007-07-24 16:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-24 17:35 Maciej W. Rozycki [this message]
2007-07-25 16:47 ` Jim Blandy
2007-07-25 17:58   ` Maciej W. Rozycki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.61.0707241727040.20726@perivale.mips.com \
    --to=macro@mips.com \
    --cc=gdb-patches@sourceware.org \
    --cc=macro@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox