Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Maciej W. Rozycki" <macro@mips.com>
To: Jim Blandy <jimb@codesourcery.com>
Cc: gdb-patches@sourceware.org, "Maciej W. Rozycki" <macro@linux-mips.org>
Subject: Re: gdb.base/dump.exp: Force the correct endianness
Date: Wed, 25 Jul 2007 17:58:00 -0000	[thread overview]
Message-ID: <Pine.LNX.4.61.0707251845500.27010@perivale.mips.com> (raw)
In-Reply-To: <m3fy3cii91.fsf@codesourcery.com>

On Wed, 25 Jul 2007, Jim Blandy wrote:

> > 2007-07-24  Maciej W. Rozycki  <macro@mips.com>
> >
> >	* gdb.base/dump.exp: Force the correct endianness for binary
> >	formats not carrying this information.
> >
> >  OK to apply?
>
> This looks reasonable --- please apply it, if you've also tested it on
> some desktop-like system.

 Well, the mips-unknown-linux-gnu host works fine natively.  I hope it
qualifies as a desktop-like system (the machine itself comes in a desktop
case if that helps).

 The "show/set endian" commands are supported universally even if the
currently chosen architecture comes in a single endianness only.  But in
that case gdb should still accept a command to force the endianness to one
already set automatically -- if that failed, it would qualify as a bug
IMO, so perhaps the change adds a useful test case as a side effect.

> Also, you should go ahead and add yourself at the proper point in the
> "Write After Approval" section of gdb/MAINTAINERS, as a separate
> commit, with a ChangeLog entry.

 Yeah, probably -- it has been too long already since I have got my
assignment sorted out.  Would it be OK to provide my both e-mail addresses
(which generally differentiate between sponsored and volunteer work) or
should I just pick one?

  Maciej


      reply	other threads:[~2007-07-25 17:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-24 17:35 Maciej W. Rozycki
2007-07-25 16:47 ` Jim Blandy
2007-07-25 17:58   ` Maciej W. Rozycki [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.61.0707251845500.27010@perivale.mips.com \
    --to=macro@mips.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jimb@codesourcery.com \
    --cc=macro@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox