From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27069 invoked by alias); 25 Jul 2007 17:53:18 -0000 Received: (qmail 27060 invoked by uid 22791); 25 Jul 2007 17:53:17 -0000 X-Spam-Check-By: sourceware.org Received: from dmz.mips-uk.com (HELO dmz.mips-uk.com) (194.74.144.194) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 25 Jul 2007 17:53:14 +0000 Received: from internal-mx1 ([192.168.192.240] helo=ukservices1.mips.com) by dmz.mips-uk.com with esmtp (Exim 3.35 #1 (Debian)) id 1IDkwd-0006pt-00; Wed, 25 Jul 2007 18:46:43 +0100 Received: from perivale.mips.com ([192.168.192.200]) by ukservices1.mips.com with esmtp (Exim 3.36 #1 (Debian)) id 1IDkwT-0000pL-00; Wed, 25 Jul 2007 18:46:33 +0100 Received: from macro (helo=localhost) by perivale.mips.com with local-esmtp (Exim 4.63) (envelope-from ) id 1IDkwT-0002Bj-19; Wed, 25 Jul 2007 18:46:33 +0100 Date: Wed, 25 Jul 2007 17:58:00 -0000 From: "Maciej W. Rozycki" To: Jim Blandy cc: gdb-patches@sourceware.org, "Maciej W. Rozycki" Subject: Re: gdb.base/dump.exp: Force the correct endianness In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-MIPS-Technologies-UK-MailScanner: Found to be clean X-MIPS-Technologies-UK-MailScanner-From: macro@mips.com Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-07/txt/msg00275.txt.bz2 On Wed, 25 Jul 2007, Jim Blandy wrote: > > 2007-07-24 Maciej W. Rozycki > > > > * gdb.base/dump.exp: Force the correct endianness for binary > > formats not carrying this information. > > > > OK to apply? > > This looks reasonable --- please apply it, if you've also tested it on > some desktop-like system. Well, the mips-unknown-linux-gnu host works fine natively. I hope it qualifies as a desktop-like system (the machine itself comes in a desktop case if that helps). The "show/set endian" commands are supported universally even if the currently chosen architecture comes in a single endianness only. But in that case gdb should still accept a command to force the endianness to one already set automatically -- if that failed, it would qualify as a bug IMO, so perhaps the change adds a useful test case as a side effect. > Also, you should go ahead and add yourself at the proper point in the > "Write After Approval" section of gdb/MAINTAINERS, as a separate > commit, with a ChangeLog entry. Yeah, probably -- it has been too long already since I have got my assignment sorted out. Would it be OK to provide my both e-mail addresses (which generally differentiate between sponsored and volunteer work) or should I just pick one? Maciej