RFA: fix 'make -jN check'

RFA: fix 'make -jN check'

[Tom Tromey]

My patch tester on the compile farm randomly failed to generate test
results.

I believe this is caused by a buglet in gdb/testsuite/Makefile.in.
Because the failure is intermittent, it is somewhat hard to be
completely certain.

I believe what happens is that the just-check target is run before
site.exp is created.  I think this is correct because if I remove
site.exp and invoke this target, I see the same sort of failure.

I don't see a reason for just-check, so I fixed this by simply making
'check' invoke runtest.  Since check depends on site.exp, this fixes
the bug.

Built and tested on the compile farm (x86-64).

Ok?

Tom

2008-07-28  Tom Tromey  <tromey@redhat.com>

	* Makefile.in (just-check): Remove.  Move body to...
	(check): ... here.

diff --git a/gdb/testsuite/Makefile.in b/gdb/testsuite/Makefile.in
index 9b55f84..b97f860 100644
--- a/gdb/testsuite/Makefile.in
+++ b/gdb/testsuite/Makefile.in
@@ -122,9 +122,7 @@ site.exp: ./config.status Makefile
 
 installcheck:
 
-check: site.exp all just-check
-
-just-check:
+check: all site.exp
 	rootme=`pwd`; export rootme; \
 	srcdir=${srcdir} ; export srcdir ; \
 	EXPECT=${EXPECT} ; export EXPECT ; \

Re: RFA: fix 'make -jN check'

[Daniel Jacobowitz]

On Mon, Jul 28, 2008 at 01:59:16PM -0600, Tom Tromey wrote:
> 2008-07-28  Tom Tromey  <tromey@redhat.com>
> 
> 	* Makefile.in (just-check): Remove.  Move body to...
> 	(check): ... here.

OK.

-- 
Daniel Jacobowitz
CodeSourcery