From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25392 invoked by alias); 28 Jul 2008 19:59:45 -0000 Received: (qmail 25379 invoked by uid 22791); 28 Jul 2008 19:59:44 -0000 X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 28 Jul 2008 19:59:21 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id m6SJxJ5m018621 for ; Mon, 28 Jul 2008 15:59:19 -0400 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [10.11.255.20]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m6SJxIIm028268; Mon, 28 Jul 2008 15:59:18 -0400 Received: from opsy.redhat.com (vpn-10-11.bos.redhat.com [10.16.10.11]) by pobox.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m6SJxHTP028906; Mon, 28 Jul 2008 15:59:18 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id C381D3784E3; Mon, 28 Jul 2008 13:59:16 -0600 (MDT) To: gdb-patches@sourceware.org Subject: RFA: fix 'make -jN check' From: Tom Tromey Reply-To: Tom Tromey X-Attribution: Tom Date: Mon, 28 Jul 2008 19:59:00 -0000 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-07/txt/msg00526.txt.bz2 My patch tester on the compile farm randomly failed to generate test results. I believe this is caused by a buglet in gdb/testsuite/Makefile.in. Because the failure is intermittent, it is somewhat hard to be completely certain. I believe what happens is that the just-check target is run before site.exp is created. I think this is correct because if I remove site.exp and invoke this target, I see the same sort of failure. I don't see a reason for just-check, so I fixed this by simply making 'check' invoke runtest. Since check depends on site.exp, this fixes the bug. Built and tested on the compile farm (x86-64). Ok? Tom 2008-07-28 Tom Tromey * Makefile.in (just-check): Remove. Move body to... (check): ... here. diff --git a/gdb/testsuite/Makefile.in b/gdb/testsuite/Makefile.in index 9b55f84..b97f860 100644 --- a/gdb/testsuite/Makefile.in +++ b/gdb/testsuite/Makefile.in @@ -122,9 +122,7 @@ site.exp: ./config.status Makefile installcheck: -check: site.exp all just-check - -just-check: +check: all site.exp rootme=`pwd`; export rootme; \ srcdir=${srcdir} ; export srcdir ; \ EXPECT=${EXPECT} ; export EXPECT ; \