Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: gdb-patches@sourceware.org
Subject: RFA: fix 'make -jN check'
Date: Mon, 28 Jul 2008 19:59:00 -0000	[thread overview]
Message-ID: <m3fxptaigb.fsf@fleche.redhat.com> (raw)

My patch tester on the compile farm randomly failed to generate test
results.

I believe this is caused by a buglet in gdb/testsuite/Makefile.in.
Because the failure is intermittent, it is somewhat hard to be
completely certain.

I believe what happens is that the just-check target is run before
site.exp is created.  I think this is correct because if I remove
site.exp and invoke this target, I see the same sort of failure.

I don't see a reason for just-check, so I fixed this by simply making
'check' invoke runtest.  Since check depends on site.exp, this fixes
the bug.

Built and tested on the compile farm (x86-64).

Ok?

Tom

2008-07-28  Tom Tromey  <tromey@redhat.com>

	* Makefile.in (just-check): Remove.  Move body to...
	(check): ... here.

diff --git a/gdb/testsuite/Makefile.in b/gdb/testsuite/Makefile.in
index 9b55f84..b97f860 100644
--- a/gdb/testsuite/Makefile.in
+++ b/gdb/testsuite/Makefile.in
@@ -122,9 +122,7 @@ site.exp: ./config.status Makefile
 
 installcheck:
 
-check: site.exp all just-check
-
-just-check:
+check: all site.exp
 	rootme=`pwd`; export rootme; \
 	srcdir=${srcdir} ; export srcdir ; \
 	EXPECT=${EXPECT} ; export EXPECT ; \


             reply	other threads:[~2008-07-28 19:59 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-28 19:59 Tom Tromey [this message]
2008-07-28 20:02 ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3fxptaigb.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox