Re: [PATCH] Remove same-pc breakpoint notification for internal BPs

[Tom Tromey <tromey@redhat.com>]

>>>>> "Kevin" == Kevin Pouget <kevin.pouget@gmail.com> writes:

Kevin> I'd like to suggest a patch which removes the message
>> (gdb) break function
>> Note: breakpoint -1 also set at pc 0x3cbd80e2a0.
>> Breakpoint 1 at 0x3cbd80e2a0
Kevin> when the user sets a breakpoint at the same PC as a _internal_
Kevin> breakpoints.

Seems reasonable to me.

Kevin> (How can I run the testsuite only for gdb.base, for instance? nothing
Kevin> should fail here, because the testsuite only matches "Note: breakpoint
Kevin> \[0-9\]+ also set...", but I would have preferred actually testing
Kevin> it!)

You should usually do full regression tests for a patch.  That is, run
before and after, and compare.

You can run just a single directory like:

  make check RUNTESTFLAGS=--directory=gdb.base

Kevin>    ALL_BREAKPOINTS (b)
Kevin> -    others += breakpoint_has_pc (b, pspace, pc, section);
Kevin> +    others += breakpoint_has_pc (b, pspace, pc, section)
Kevin> +      && b->number >= 0;

You need parens around the RHS here and more indentation on the second
line.

Tom