From: Kevin Pouget <kevin.pouget@gmail.com>
To: Pedro Alves <pedro@codesourcery.com>
Cc: Tom Tromey <tromey@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Remove same-pc breakpoint notification for internal BPs
Date: Wed, 27 Apr 2011 13:03:00 -0000 [thread overview]
Message-ID: <BANLkTikdW7-L_WaLebZuVWRouMRXwXeMNg@mail.gmail.com> (raw)
In-Reply-To: <201104211627.20994.pedro@codesourcery.com>
Hello,
here is an updated version of the patch, which uses `user_breakpoint_p'
thanks,
Kevin (still waiting for copyright papers)
--
2011-04-27 Kevin Pouget <kevin.pouget@st.com>
* breakpoint.c (describe_other_breakpoints): Do not write 'duplicate'
note if the breakpoint is internal.
diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c
index 2352191..3474caf 100644
--- a/gdb/breakpoint.c
+++ b/gdb/breakpoint.c
@@ -5397,7 +5397,7 @@ breakpoint_has_pc (struct breakpoint *b,
return 0;
}
-/* Print a message describing any breakpoints set at PC. This
+/* Print a message describing any user-breakpoints set at PC. This
concerns with logical breakpoints, so we match program spaces, not
address spaces. */
@@ -5410,7 +5410,8 @@ describe_other_breakpoints (struct gdbarch *gdbarch,
struct breakpoint *b;
ALL_BREAKPOINTS (b)
- others += breakpoint_has_pc (b, pspace, pc, section);
+ others += (breakpoint_has_pc (b, pspace, pc, section)
+ && user_breakpoint_p (b));
if (others > 0)
{
if (others == 1)
@@ -5418,7 +5419,7 @@ describe_other_breakpoints (struct gdbarch *gdbarch,
else /* if (others == ???) */
printf_filtered (_("Note: breakpoints "));
ALL_BREAKPOINTS (b)
- if (breakpoint_has_pc (b, pspace, pc, section))
+ if (breakpoint_has_pc (b, pspace, pc, section) && user_breakpoint_p (b))
{
others--;
printf_filtered ("%d", b->number);
--
next prev parent reply other threads:[~2011-04-27 13:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-20 13:44 Kevin Pouget
2011-04-20 13:57 ` Kevin Pouget
2011-04-20 19:03 ` Tom Tromey
2011-04-21 8:12 ` Kevin Pouget
2011-04-21 8:49 ` Pedro Alves
2011-04-21 9:25 ` Kevin Pouget
2011-04-21 9:34 ` Kevin Pouget
2011-04-21 14:17 ` Tom Tromey
2011-04-21 14:59 ` Pedro Alves
2011-04-21 15:06 ` Tom Tromey
2011-04-21 15:27 ` Pedro Alves
2011-04-27 13:03 ` Kevin Pouget [this message]
2011-08-31 13:18 ` Kevin Pouget
2011-09-05 14:43 ` Pedro Alves
2011-09-15 12:31 ` Kevin Pouget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTikdW7-L_WaLebZuVWRouMRXwXeMNg@mail.gmail.com \
--to=kevin.pouget@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox