From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16267 invoked by alias); 27 Apr 2011 13:03:13 -0000 Received: (qmail 16259 invoked by uid 22791); 27 Apr 2011 13:03:13 -0000 X-SWARE-Spam-Status: No, hits=-1.4 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RFC_ABUSE_POST X-Spam-Check-By: sourceware.org Received: from mail-vx0-f169.google.com (HELO mail-vx0-f169.google.com) (209.85.220.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 27 Apr 2011 13:02:39 +0000 Received: by vxk20 with SMTP id 20so1663703vxk.0 for ; Wed, 27 Apr 2011 06:02:38 -0700 (PDT) Received: by 10.52.161.65 with SMTP id xq1mr3201599vdb.68.1303909358058; Wed, 27 Apr 2011 06:02:38 -0700 (PDT) MIME-Version: 1.0 Received: by 10.220.61.6 with HTTP; Wed, 27 Apr 2011 06:02:18 -0700 (PDT) In-Reply-To: <201104211627.20994.pedro@codesourcery.com> References: <201104211559.40948.pedro@codesourcery.com> <201104211627.20994.pedro@codesourcery.com> From: Kevin Pouget Date: Wed, 27 Apr 2011 13:03:00 -0000 Message-ID: Subject: Re: [PATCH] Remove same-pc breakpoint notification for internal BPs To: Pedro Alves Cc: Tom Tromey , gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-04/txt/msg00502.txt.bz2 Hello, here is an updated version of the patch, which uses `user_breakpoint_p' thanks, Kevin (still waiting for copyright papers) -- 2011-04-27 Kevin Pouget * breakpoint.c (describe_other_breakpoints): Do not write 'duplicate' note if the breakpoint is internal. diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c index 2352191..3474caf 100644 --- a/gdb/breakpoint.c +++ b/gdb/breakpoint.c @@ -5397,7 +5397,7 @@ breakpoint_has_pc (struct breakpoint *b, return 0; } -/* Print a message describing any breakpoints set at PC. This +/* Print a message describing any user-breakpoints set at PC. This concerns with logical breakpoints, so we match program spaces, not address spaces. */ @@ -5410,7 +5410,8 @@ describe_other_breakpoints (struct gdbarch *gdbarch, struct breakpoint *b; ALL_BREAKPOINTS (b) - others += breakpoint_has_pc (b, pspace, pc, section); + others += (breakpoint_has_pc (b, pspace, pc, section) + && user_breakpoint_p (b)); if (others > 0) { if (others == 1) @@ -5418,7 +5419,7 @@ describe_other_breakpoints (struct gdbarch *gdbarch, else /* if (others == ???) */ printf_filtered (_("Note: breakpoints ")); ALL_BREAKPOINTS (b) - if (breakpoint_has_pc (b, pspace, pc, section)) + if (breakpoint_has_pc (b, pspace, pc, section) && user_breakpoint_p (b)) { others--; printf_filtered ("%d", b->number); --