Re: [PATCH] Remove same-pc breakpoint notification for internal BPs

[Kevin Pouget <kevin.pouget@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 554 bytes --]

On Wed, Apr 27, 2011 at 3:02 PM, Kevin Pouget <kevin.pouget@gmail.com> wrote:
> Hello,
>
> here is an updated version of the patch, which uses `user_breakpoint_p'
>
>
> thanks,
>
> Kevin (still waiting for copyright papers)


Hello,

this patch was not explicitly approved when I first submitted it,  but
all the concerns were addressed; please let me not if it looks good to
you


Thanks,

Kevin

2011-08-31  Kevin Pouget  <kevin.pouget@st.com>
	* breakpoint.c (describe_other_breakpoints): Do not write 'duplicate'
	note if the breakpoint is internal.

[-- Attachment #2: 0001-Remove-same-pc-breakpoint-notification-for-internal-.patch --]
[-- Type: text/x-patch, Size: 1467 bytes --]

From 421d1625f761c4987f8315a272d3bbfbfe14a52e Mon Sep 17 00:00:00 2001
From: Kevin Pouget <kevin.pouget@st.com>
Date: Wed, 20 Apr 2011 15:36:51 -0400
Subject: [PATCH] Remove same-pc breakpoint notification for internal BPs

---
 gdb/breakpoint.c |    7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c
index 2352191..3474caf 100644
--- a/gdb/breakpoint.c
+++ b/gdb/breakpoint.c
@@ -5397,7 +5397,7 @@ breakpoint_has_pc (struct breakpoint *b,
   return 0;
 }
 
-/* Print a message describing any breakpoints set at PC.  This
+/* Print a message describing any user-breakpoints set at PC.  This
    concerns with logical breakpoints, so we match program spaces, not
    address spaces.  */
 
@@ -5410,7 +5410,8 @@ describe_other_breakpoints (struct gdbarch *gdbarch,
   struct breakpoint *b;
 
   ALL_BREAKPOINTS (b)
-    others += breakpoint_has_pc (b, pspace, pc, section);
+    others += (breakpoint_has_pc (b, pspace, pc, section)
+               && user_breakpoint_p (b));
   if (others > 0)
     {
       if (others == 1)
@@ -5418,7 +5419,7 @@ describe_other_breakpoints (struct gdbarch *gdbarch,
       else /* if (others == ???) */
 	printf_filtered (_("Note: breakpoints "));
       ALL_BREAKPOINTS (b)
-	if (breakpoint_has_pc (b, pspace, pc, section))
+	if (breakpoint_has_pc (b, pspace, pc, section) && user_breakpoint_p (b))
 	  {
 	    others--;
 	    printf_filtered ("%d", b->number);
-- 
1.7.6