From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28557 invoked by alias); 20 Apr 2011 19:03:21 -0000 Received: (qmail 28549 invoked by uid 22791); 20 Apr 2011 19:03:21 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 20 Apr 2011 19:03:04 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p3KJ324k019392 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 20 Apr 2011 15:03:02 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p3KJ32As014735; Wed, 20 Apr 2011 15:03:02 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p3KJ31Sp022082; Wed, 20 Apr 2011 15:03:01 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 6E81737808F; Wed, 20 Apr 2011 13:03:01 -0600 (MDT) From: Tom Tromey To: Kevin Pouget Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Remove same-pc breakpoint notification for internal BPs References: Date: Wed, 20 Apr 2011 19:03:00 -0000 In-Reply-To: (Kevin Pouget's message of "Wed, 20 Apr 2011 09:43:44 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-04/txt/msg00369.txt.bz2 >>>>> "Kevin" == Kevin Pouget writes: Kevin> I'd like to suggest a patch which removes the message >> (gdb) break function >> Note: breakpoint -1 also set at pc 0x3cbd80e2a0. >> Breakpoint 1 at 0x3cbd80e2a0 Kevin> when the user sets a breakpoint at the same PC as a _internal_ Kevin> breakpoints. Seems reasonable to me. Kevin> (How can I run the testsuite only for gdb.base, for instance? nothing Kevin> should fail here, because the testsuite only matches "Note: breakpoint Kevin> \[0-9\]+ also set...", but I would have preferred actually testing Kevin> it!) You should usually do full regression tests for a patch. That is, run before and after, and compare. You can run just a single directory like: make check RUNTESTFLAGS=--directory=gdb.base Kevin> ALL_BREAKPOINTS (b) Kevin> - others += breakpoint_has_pc (b, pspace, pc, section); Kevin> + others += breakpoint_has_pc (b, pspace, pc, section) Kevin> + && b->number >= 0; You need parens around the RHS here and more indentation on the second line. Tom