From: Sergio Durigan Junior <sergiodj@redhat.com>
To: John Lindal <support_0384@newplanetsoftware.com>
Cc: gdb-patches@sourceware.org
Subject: Re: Allow -data-disassemble to run with only -s option
Date: Tue, 09 Aug 2011 03:06:00 -0000 [thread overview]
Message-ID: <m3ei0v9tcn.fsf@redhat.com> (raw)
In-Reply-To: <m3mxfj9tre.fsf@redhat.com> (Sergio Durigan Junior's message of "Mon, 08 Aug 2011 23:57:25 -0300")
Sorry, I made some mistakes. See below.
Sergio Durigan Junior <sergiodj@redhat.com> writes:
> John Lindal <support_0384@newplanetsoftware.com> writes:
>> 2011-08-06 John Lindal <gdb@newplanetsoftware.com>
>>
>> * mi-cmd-disas.c: Accept only -s option. Automatically set end to end
>> of function, or complain that start address is not part of any function.
>
> I think those lines are too long. We try to limit the lines on 80
> characteres (some people set a hard limit at 72, IIRC).
Actually the length is OK here.
>> + if (!line_seen && !file_seen && !num_seen && start_seen && !end_seen)
>
> Same issue here.
And here too.
Sorry about the confusion.
next prev parent reply other threads:[~2011-08-09 3:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-06 22:29 John Lindal
2011-08-08 20:26 ` Tom Tromey
2011-08-09 1:00 ` John Lindal
2011-08-09 2:57 ` Sergio Durigan Junior
2011-08-09 3:06 ` Sergio Durigan Junior [this message]
2011-08-09 16:33 ` John Lindal
2011-08-12 19:32 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3ei0v9tcn.fsf@redhat.com \
--to=sergiodj@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=support_0384@newplanetsoftware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox