From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-82910-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 30959 invoked by alias); 9 Aug 2011 03:06:39 -0000
Received: (qmail 30949 invoked by uid 22791); 9 Aug 2011 03:06:38 -0000
X-SWARE-Spam-Status: No, hits=-6.9 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 09 Aug 2011 03:06:23 +0000
Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p7936M8G030759	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Mon, 8 Aug 2011 23:06:22 -0400
Received: from psique ([10.3.112.5])	by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p7936Hho014265;	Mon, 8 Aug 2011 23:06:19 -0400
From: Sergio Durigan Junior <sergiodj@redhat.com>
To: John Lindal <support_0384@newplanetsoftware.com>
Cc: gdb-patches@sourceware.org
Subject: Re: Allow -data-disassemble to run with only -s option
References: <587BFD3C-0540-49FA-87F9-89CBBF2FF010@newplanetsoftware.com>	<m362m7veed.fsf@fleche.redhat.com>	<3DBE6912-1DE6-4B8B-8353-96855B07268E@newplanetsoftware.com>	<m3mxfj9tre.fsf@redhat.com>
Date: Tue, 09 Aug 2011 03:06:00 -0000
In-Reply-To: <m3mxfj9tre.fsf@redhat.com> (Sergio Durigan Junior's message of	"Mon, 08 Aug 2011 23:57:25 -0300")
Message-ID: <m3ei0v9tcn.fsf@redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-08/txt/msg00170.txt.bz2

Sorry, I made some mistakes.  See below.

Sergio Durigan Junior <sergiodj@redhat.com> writes:

> John Lindal <support_0384@newplanetsoftware.com> writes:
>> 2011-08-06 John Lindal <gdb@newplanetsoftware.com>
>>
>> 	* mi-cmd-disas.c: Accept only -s option.  Automatically set end to end
>> 	of function, or complain that start address is not part of any function.
>
> I think those lines are too long.  We try to limit the lines on 80
> characteres (some people set a hard limit at 72, IIRC).

Actually the length is OK here.

>> +   if (!line_seen && !file_seen && !num_seen && start_seen && !end_seen)
>
> Same issue here.

And here too.

Sorry about the confusion.