From: John Lindal <support_0384@newplanetsoftware.com>
To: gdb-patches@sourceware.org
Cc: gdb@newplanetsoftware.com
Subject: Allow -data-disassemble to run with only -s option
Date: Sat, 06 Aug 2011 22:29:00 -0000 [thread overview]
Message-ID: <587BFD3C-0540-49FA-87F9-89CBBF2FF010@newplanetsoftware.com> (raw)
Since the "disassemble" command only requires the function name, I
figured it would be nice if -data-disassemble did not require the
ending address. The attached patch makes the end address (-e option)
optional. This is backward compatible, since all existing code that
calls -data-disassemble passes both -s and -e.
Sincerely,
John Lindal
New Planet Software
http://www.newplanetsoftware.com/
twitter: newplanetsw
-----
2011-08-06 John Lindal <gdb@newplanetsoftware.com>
* mi-cmd-disas.c: Accept only -s option. Automatically set end to end
of function, or complain that start address is not part of any
function.
-----
*** mi/mi-cmd-disas.c~ 2011-03-09 12:31:50.000000000 -0800
--- mi/mi-cmd-disas.c 2011-08-06 15:14:55.000000000 -0700
***************
*** 37,42 ****
--- 37,47 ----
or:
+ START-ADDRESS: address to start the disassembly at.
+ (END-ADDRESS is the end of the function.)
+
+ or:
+
FILENAME: The name of the file where we want disassemble from.
LINE: The line around which we want to disassemble. It will
disassemble the function that contins that line.
*************** mi_cmd_disassemble (char *command, char
*** 127,132 ****
--- 132,147 ----
argv += optind;
argc -= optind;
+ if (!line_seen && !file_seen && !num_seen && start_seen && !
end_seen)
+ {
+ char* ignore_name;
+ CORE_ADDR ignore_low;
+ if (find_pc_partial_function (low, &ignore_name, &ignore_low,
&high) == 0)
+ error (_("No function contains specified address"));
+
+ end_seen = 1;
+ }
+
/* Allow only filename + linenum (with how_many which is not
required) OR start_addr + and_addr */
*************** mi_cmd_disassemble (char *command, char
*** 134,144 ****
|| (line_seen && file_seen && !num_seen && !start_seen && !end_seen)
|| (!line_seen && !file_seen && !num_seen && start_seen &&
end_seen)))
error (_("-data-disassemble: Usage: ( [-f filename -l linenum [-
n "
! "howmany]] | [-s startaddr -e endaddr]) [--] mode."));
if (argc != 1)
error (_("-data-disassemble: Usage: [-f filename -l linenum "
! "[-n howmany]] [-s startaddr -e endaddr] [--] mode."));
mode = atoi (argv[0]);
if (mode < 0 || mode > 3)
--- 149,159 ----
|| (line_seen && file_seen && !num_seen && !start_seen && !end_seen)
|| (!line_seen && !file_seen && !num_seen && start_seen &&
end_seen)))
error (_("-data-disassemble: Usage: ( [-f filename -l linenum [-
n "
! "howmany]] | [-s startaddr [-e endaddr]]) [--] mode."));
if (argc != 1)
error (_("-data-disassemble: Usage: [-f filename -l linenum "
! "[-n howmany]] [-s startaddr [-e endaddr]] [--] mode."));
mode = atoi (argv[0]);
if (mode < 0 || mode > 3)
next reply other threads:[~2011-08-06 22:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-06 22:29 John Lindal [this message]
2011-08-08 20:26 ` Tom Tromey
2011-08-09 1:00 ` John Lindal
2011-08-09 2:57 ` Sergio Durigan Junior
2011-08-09 3:06 ` Sergio Durigan Junior
2011-08-09 16:33 ` John Lindal
2011-08-12 19:32 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=587BFD3C-0540-49FA-87F9-89CBBF2FF010@newplanetsoftware.com \
--to=support_0384@newplanetsoftware.com \
--cc=gdb-patches@sourceware.org \
--cc=gdb@newplanetsoftware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox