From: Tom Tromey <tromey@redhat.com>
To: John Lindal <support_0384@newplanetsoftware.com>
Cc: gdb-patches@sourceware.org, gdb@newplanetsoftware.com
Subject: Re: Allow -data-disassemble to run with only -s option
Date: Mon, 08 Aug 2011 20:26:00 -0000 [thread overview]
Message-ID: <m362m7veed.fsf@fleche.redhat.com> (raw)
In-Reply-To: <587BFD3C-0540-49FA-87F9-89CBBF2FF010@newplanetsoftware.com> (John Lindal's message of "Sat, 6 Aug 2011 15:28:38 -0700")
>>>>> "John" == John Lindal <support_0384@newplanetsoftware.com> writes:
John> Since the "disassemble" command only requires the function name, I
John> figured it would be nice if -data-disassemble did not require the
John> ending address. The attached patch makes the end address (-e option)
John> optional. This is backward compatible, since all existing code that
John> calls -data-disassemble passes both -s and -e.
Do you have a copyright assignment in place?
If not, contact me off-list and I will get you started.
This patch needs a documentation update.
A test case would be nice.
A few minor nits.
John> + if (!line_seen && !file_seen && !num_seen && start_seen &&
John> !end_seen)
Your mailer mangled the patch.
John> + {
John> + char* ignore_name;
Wrong formatting, "char *ignore_name".
John> + CORE_ADDR ignore_low;
John> + if (find_pc_partial_function (low, &ignore_name, &ignore_low,
Blank line between declarations and code.
Tom
next prev parent reply other threads:[~2011-08-08 20:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-06 22:29 John Lindal
2011-08-08 20:26 ` Tom Tromey [this message]
2011-08-09 1:00 ` John Lindal
2011-08-09 2:57 ` Sergio Durigan Junior
2011-08-09 3:06 ` Sergio Durigan Junior
2011-08-09 16:33 ` John Lindal
2011-08-12 19:32 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m362m7veed.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=gdb@newplanetsoftware.com \
--cc=support_0384@newplanetsoftware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox