From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2543 invoked by alias); 8 Aug 2011 20:26:30 -0000 Received: (qmail 2534 invoked by uid 22791); 8 Aug 2011 20:26:30 -0000 X-SWARE-Spam-Status: No, hits=-7.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 08 Aug 2011 20:26:05 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p78KQ4vs018059 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 8 Aug 2011 16:26:04 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p78KQ3rn000809; Mon, 8 Aug 2011 16:26:03 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p78KQ20E000419; Mon, 8 Aug 2011 16:26:02 -0400 From: Tom Tromey To: John Lindal Cc: gdb-patches@sourceware.org, gdb@newplanetsoftware.com Subject: Re: Allow -data-disassemble to run with only -s option References: <587BFD3C-0540-49FA-87F9-89CBBF2FF010@newplanetsoftware.com> Date: Mon, 08 Aug 2011 20:26:00 -0000 In-Reply-To: <587BFD3C-0540-49FA-87F9-89CBBF2FF010@newplanetsoftware.com> (John Lindal's message of "Sat, 6 Aug 2011 15:28:38 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-08/txt/msg00155.txt.bz2 >>>>> "John" == John Lindal writes: John> Since the "disassemble" command only requires the function name, I John> figured it would be nice if -data-disassemble did not require the John> ending address. The attached patch makes the end address (-e option) John> optional. This is backward compatible, since all existing code that John> calls -data-disassemble passes both -s and -e. Do you have a copyright assignment in place? If not, contact me off-list and I will get you started. This patch needs a documentation update. A test case would be nice. A few minor nits. John> + if (!line_seen && !file_seen && !num_seen && start_seen && John> !end_seen) Your mailer mangled the patch. John> + { John> + char* ignore_name; Wrong formatting, "char *ignore_name". John> + CORE_ADDR ignore_low; John> + if (find_pc_partial_function (low, &ignore_name, &ignore_low, Blank line between declarations and code. Tom