From: Tom Tromey <tromey@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: Marc Khouzam <marc.khouzam@ericsson.com>,
"'gdb-patches\@sourceware.org'"
<gdb-patches@sourceware.org>
Subject: Re: [MI] Duplicate --thread-group flag not detected
Date: Thu, 02 Dec 2010 16:40:00 -0000 [thread overview]
Message-ID: <m3bp54ku1x.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20101126163842.GJ2634@adacore.com> (Joel Brobecker's message of "Fri, 26 Nov 2010 08:38:42 -0800")
>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:
>> 2010-11-25 Marc Khouzam <marc.khouzam@ericsson.com>
>>
>> * mi/mi-parse.c (mi_parse): Missing else.
Joel> Normally, the man to approve this is Vladimir, so I can't approve, but
Joel> I had a quick look anyway.
I think in this case the patch is simple and obvious enough that we can
go forward without waiting.
What do you think of that?
Joel> Another remark: It looks like the use of the --all/--thread-group/--thread
Joel> options with the -mi-break command is not documented? I could only see
Joel> them documented with commands such as -exec-continue....
This code seems weird to me too. I suppose it is needed until the
transition to "new" style argv commands is completed.
I was curious about this -- is this sort of transition something people
would want to see done? Would it help MI users? (It would help Python
if we ever implemented the automatic MI wrapping... but I am not sure
whether we really want to do that.)
From what I can see there are 14 such commands.
Joel> Last comment: A small test would be nice...
I agree.
Tom
next prev parent reply other threads:[~2010-12-02 16:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-25 20:56 Marc Khouzam
2010-11-26 16:39 ` Joel Brobecker
2010-12-02 16:40 ` Tom Tromey [this message]
2010-12-02 17:10 ` Joel Brobecker
2010-12-04 18:10 ` Marc Khouzam
2010-12-04 18:47 ` Joel Brobecker
2010-12-05 19:27 ` Marc Khouzam
2010-12-06 11:04 ` Joel Brobecker
2010-12-06 14:26 ` Marc Khouzam
2010-12-06 15:02 ` [MI] --thread-group test (was: RE: [MI] Duplicate --thread-group flag not detected) Marc Khouzam
2010-12-10 12:15 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3bp54ku1x.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=marc.khouzam@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox