From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18760 invoked by alias); 2 Dec 2010 16:40:28 -0000 Received: (qmail 18707 invoked by uid 22791); 2 Dec 2010 16:40:27 -0000 X-SWARE-Spam-Status: No, hits=-6.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,TW_RG,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 02 Dec 2010 16:40:22 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id oB2GduDc006901 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 2 Dec 2010 11:39:56 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id oB2Gduis016634; Thu, 2 Dec 2010 11:39:56 -0500 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id oB2Gdt5e004642; Thu, 2 Dec 2010 11:39:55 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id E827837817D; Thu, 2 Dec 2010 09:39:54 -0700 (MST) From: Tom Tromey To: Joel Brobecker Cc: Marc Khouzam , "'gdb-patches\@sourceware.org'" Subject: Re: [MI] Duplicate --thread-group flag not detected References: <20101126163842.GJ2634@adacore.com> Date: Thu, 02 Dec 2010 16:40:00 -0000 In-Reply-To: <20101126163842.GJ2634@adacore.com> (Joel Brobecker's message of "Fri, 26 Nov 2010 08:38:42 -0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-12/txt/msg00015.txt.bz2 >>>>> "Joel" == Joel Brobecker writes: >> 2010-11-25 Marc Khouzam >> >> * mi/mi-parse.c (mi_parse): Missing else. Joel> Normally, the man to approve this is Vladimir, so I can't approve, but Joel> I had a quick look anyway. I think in this case the patch is simple and obvious enough that we can go forward without waiting. What do you think of that? Joel> Another remark: It looks like the use of the --all/--thread-group/--thread Joel> options with the -mi-break command is not documented? I could only see Joel> them documented with commands such as -exec-continue.... This code seems weird to me too. I suppose it is needed until the transition to "new" style argv commands is completed. I was curious about this -- is this sort of transition something people would want to see done? Would it help MI users? (It would help Python if we ever implemented the automatic MI wrapping... but I am not sure whether we really want to do that.) >From what I can see there are 14 such commands. Joel> Last comment: A small test would be nice... I agree. Tom