RE: [MI] Duplicate --thread-group flag not detected

[Marc Khouzam <marc.khouzam@ericsson.com>]

 

> -----Original Message-----
> From: Joel Brobecker [mailto:brobecker@adacore.com] 
> Sent: Monday, December 06, 2010 6:04 AM
> To: Marc Khouzam
> Cc: Tom Tromey; 'gdb-patches@sourceware.org'
> Subject: Re: [MI] Duplicate --thread-group flag not detected
> 
> > You make it hard to say no :-)
> 
> :-D
> 
> > So here's my attempt at new tests for these cases.  I wasn't sure
> > where to put it so I created a new mi-general.exp test which should
> > eventually test the parsing of general MI syntax, including the
> > --thread-group, --thread, --frame, --all, --reverse, flags.
> 
> OK. I propose we treat this patch as separate. Please just go ahead
> with the code part, while we review the testing part.

I'll email separately for the testcase then.

I committed the code part to HEAD and 7_2

2010-12-06  Marc Khouzam  <marc.khouzam@ericsson.com>

	* mi/mi-parse.c (mi_parse): Missing else.
        
### Eclipse Workspace Patch 1.0
#P src
Index: gdb/mi/mi-parse.c
===================================================================
RCS file: /cvs/src/src/gdb/mi/mi-parse.c,v
retrieving revision 1.21
diff -u -r1.21 mi-parse.c
--- gdb/mi/mi-parse.c   17 May 2010 20:49:39 -0000      1.21
+++ gdb/mi/mi-parse.c   5 Dec 2010 19:07:26 -0000
@@ -319,7 +319,7 @@
          chp += 1;
          parse->thread_group = strtol (chp, &chp, 10);
        }
-      if (strncmp (chp, "--thread ", ts) == 0)
+      else if (strncmp (chp, "--thread ", ts) == 0)
        {
          if (parse->thread != -1)
            error (_("Duplicate '--thread' option"));